GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100288: Specialise LOAD_ATTR_METHOD for managed dictionaries by Fidget-Spinner · Pull Request #100492 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Dec 24, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Finish up LOAD_ATTR specialisation #100288

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Fidget-Spinner and others added 6 commits December 16, 2022 16:44
@Fidget-Spinner
Specialize LOAD_ATTR for managed dicts
55a29e9
@Fidget-Spinner
Remove a temp file
e209b9e
@blurb-it
📜🤖 Added by blurb_it.
9e7862b
@Fidget-Spinner
Access the correct dict
1aecb3c
@Fidget-Spinner
Merge branch 'more_load_attr' of https://github.com/Fidget-Spinner/cp…
fe02743
…ython into more_load_attr
@Fidget-Spinner
Merge remote-tracking branch 'origin/main' into more_load_attr
576c914
@bedevere-bot bedevere-bot mentioned this pull request Dec 24, 2022
Finish up LOAD_ATTR specialisation #100288
Closed
1 of 2 tasks
@bedevere-bot bedevere-bot added the awaiting core review label Dec 24, 2022
@Fidget-Spinner Fidget-Spinner added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 24, 2022
@bedevere-bot

bedevere-bot commented Dec 24, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @Fidget-Spinner for commit 576c914 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 24, 2022
brandtbucher
brandtbucher reviewed Dec 27, 2022
View reviewed changes
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@Fidget-Spinner
Implement Brandt's suggestion
b32f188
@Fidget-Spinner
Fidget-Spinner requested a review from markshannon January 3, 2023 14:26
@markshannon

markshannon commented Jan 3, 2023

Copy link
Copy Markdown
Member

The stats show only a small increase in specialization effectiveness, and that the new instruction has a 40% miss rate.

I think we would be better off trying to reduce the number of objects with dictionaries than specializing for that case.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Fidget-Spinner

Fidget-Spinner commented Jan 3, 2023

Copy link
Copy Markdown
Member Author

Hmm yes hit rate only went from 82.0% to 82.5%. This isn't worthwhile.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Fidget-Spinner Fidget-Spinner closed this Jan 4, 2023
@Fidget-Spinner
Fidget-Spinner deleted the more_load_attr branch January 4, 2023 11:53
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jan 4, 2023
Race condition in subinterpreters during subinterpreter creation on Windows debug build #100711
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher left review comments
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Fidget-Spinner @bedevere-bot @markshannon @brandtbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.