GeezerVison is showing github.com — gh-99908 Update 'odds and ends' `class` documentation by JosephSBoyle · Pull Request #100498 · python/cpython
Conversation
JosephSBoyle
commented
Dec 24, 2022
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Note: Closed the last PR due to issues with the CLA bot and modified commit authorship (incorrect email was used for my commit).
Modernizes an example in the 'odds and ends' section of the documentation about classes.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
The following commit authors need to sign the Contributor License Agreement:
Click the button to sign:

|
JosephSBoyle and AlexWaygood reacted with thumbs down emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|

I don't understand why the CLA bot thinks that '[email protected]' needs to sign; I can't see that email in the git history!
Can we ignore it?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Unfortunately, the CLA check is "required" in our CI, meaning that we are physically incapable of merging if the check fails. You can see that the "squash and merge" button just isn't available to me on this PR:

|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@AlexWaygood Okay, understood, I'll make a figure it out and let you know when it's sorted!
🖖
|
AlexWaygood reacted with heart emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.

I don't understand why the CLA bot thinks that '[email protected]' needs to sign; I can't see that email in the git history!
Can we ignore it?
Perhaps @ambv can help with this, as one of the authors of the CLA bot :)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Just to note, if I pull this branch and use git log or git show -q de102b1, I get the [email protected] address as the author, and the same if I check it via the GitHub API (which is what the bot uses). Therefore, the bot operating exactly as it should, as the actual commit pushed to the PR branch has the author set as [email protected].

If we look at your screenshot, we can see what is going on—the commit in question is marked replaced, which means the commit being shown locally is not the actual original commit de102b1 , but rather a modified version only visible to you locally. This means either you or a tool you used performed a git replace operation on the commit, and that presumably changed the author email. However, that is not visible external to your local repo, at least without special steps. If you run git --no-replace-objects log, you'll see the actual original commit that was pushed here. For an in depth look at how git replace works, see this SO answer.
Presumably, in your revised PR, you amended/squashed the original commit(s), which created an actual new commit that could then be pushed here.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|