GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99908 Update 'odds and ends' `class` documentation by JosephSBoyle · Pull Request #100498 · python/cpython

Conversation

@JosephSBoyle

@JosephSBoyle JosephSBoyle commented Dec 24, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Note: Closed the last PR due to issues with the CLA bot and modified commit authorship (incorrect email was used for my commit).

Modernizes an example in the 'odds and ends' section of the documentation about classes.

  • Issue: classes odds and ends could mention dataclasses #99908

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Joe Boyle and others added 3 commits December 24, 2022 13:09
Joe Boyle @JosephSBoyle
pythongh-99908 Update class documentation to use a modernized example
de102b1
@hauntsaninja @JosephSBoyle
Newline to separate interactive section, like above examples
f97869a
@hauntsaninja @JosephSBoyle
Use interpreter output, not comments, like with Dog example
3021b7c
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Dec 24, 2022
@ghost

ghost commented Dec 24, 2022

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

  • [email protected]

Click the button to sign:
CLA not signed

JosephSBoyle and AlexWaygood reacted with thumbs down emoji
All reactions
  • 👎 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JosephSBoyle

JosephSBoyle commented Dec 24, 2022

Copy link
Copy Markdown
Contributor Author

image

I don't understand why the CLA bot thinks that '[email protected]' needs to sign; I can't see that email in the git history!

Can we ignore it?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JosephSBoyle JosephSBoyle changed the title Fix issue 99908 gh-99908 Update 'odds and ends' class documentation Dec 24, 2022
@bedevere-bot bedevere-bot mentioned this pull request Dec 24, 2022
classes odds and ends could mention dataclasses #99908
Closed
@AlexWaygood

AlexWaygood commented Dec 24, 2022

Copy link
Copy Markdown
Member

Unfortunately, the CLA check is "required" in our CI, meaning that we are physically incapable of merging if the check fails. You can see that the "squash and merge" button just isn't available to me on this PR:

8FA85DBB-D79B-4EED-B66D-29B347CF8502

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JosephSBoyle

JosephSBoyle commented Dec 24, 2022

Copy link
Copy Markdown
Contributor Author

@AlexWaygood Okay, understood, I'll make a figure it out and let you know when it's sorted!

🖖

AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood

AlexWaygood commented Dec 24, 2022

Copy link
Copy Markdown
Member

image

I don't understand why the CLA bot thinks that '[email protected]' needs to sign; I can't see that email in the git history!

Can we ignore it?

Perhaps @ambv can help with this, as one of the authors of the CLA bot :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood

AlexWaygood commented Dec 24, 2022

Copy link
Copy Markdown
Member

Closing in favour of #100499

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood AlexWaygood closed this Dec 24, 2022
@CAM-Gerlach

CAM-Gerlach commented Dec 24, 2022

Copy link
Copy Markdown
Member

Just to note, if I pull this branch and use git log or git show -q de102b1, I get the [email protected] address as the author, and the same if I check it via the GitHub API (which is what the bot uses). Therefore, the bot operating exactly as it should, as the actual commit pushed to the PR branch has the author set as [email protected].

image

If we look at your screenshot, we can see what is going on—the commit in question is marked replaced, which means the commit being shown locally is not the actual original commit de102b1 , but rather a modified version only visible to you locally. This means either you or a tool you used performed a git replace operation on the commit, and that presumably changed the author email. However, that is not visible external to your local repo, at least without special steps. If you run git --no-replace-objects log, you'll see the actual original commit that was pushed here. For an in depth look at how git replace works, see this SO answer.

Presumably, in your revised PR, you amended/squashed the original commit(s), which created an actual new commit that could then be pushed here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JosephSBoyle @AlexWaygood @CAM-Gerlach @bedevere-bot @hauntsaninja
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.