GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-100287: Fix unittest.mock.seal with AsyncMock (GH-100496) by hauntsaninja · Pull Request #100506 · python/cpython

Conversation

@hauntsaninja

@hauntsaninja hauntsaninja commented Dec 24, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit e4b43eb)

Co-authored-by: Shantanu [email protected]

  • Issue: unittest.mock.seal doesn't work as expected with AsyncMock #100287

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hauntsaninja
[3.11] pythongh-100287: Fix unittest.mock.seal with AsyncMock (python…
a912701
…GH-100496)

(cherry picked from commit e4b43eb)

Co-authored-by: Shantanu <[email protected]>
@hauntsaninja
hauntsaninja requested a review from cjw296 as a code owner December 24, 2022 20:06
This was referenced Dec 24, 2022
unittest.mock.seal doesn't work as expected with AsyncMock #100287
Closed
gh-100287: Fix unittest.mock.seal with AsyncMock #100496
Merged
@bedevere-bot bedevere-bot added the awaiting core review label Dec 24, 2022
JelleZijlstra
JelleZijlstra approved these changes Dec 24, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Dec 24, 2022
@hauntsaninja
hauntsaninja merged commit 75b75df into python:3.11 Dec 24, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 24, 2022
@hauntsaninja
hauntsaninja deleted the backport-e4b43eb-3.11 branch December 24, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@cjw296 cjw296 Awaiting requested review from cjw296 cjw296 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hauntsaninja @JelleZijlstra @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.