GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-92446: Improve argparse choices docs (GH-94627) by hauntsaninja · Pull Request #100529 · python/cpython

Conversation

@hauntsaninja

@hauntsaninja hauntsaninja commented Dec 26, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Based on the definition of the collections.abc classes, it is more accurate to use "sequence" instead of "container" when describing argparse choices.

(cherry picked from commit ad3c99e)

Co-authored-by: Guy Yagev [email protected]
Co-authored-by: Shantanu [email protected]

  • Issue: Argparse choices should be a sequence #92446

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@yourlefthandman @hauntsaninja
[3.10] pythongh-92446: Improve argparse choices docs; revert bad chan…
1bf98a9
…ge to lzma docs (pythonGH-94627)

Based on the definition of the collections.abc classes, it is more accurate to use "sequence" instead of "container" when describing argparse choices.

A previous attempt at fixing this in pythonGH-92450 was mistaken; this PR reverts that change.

(cherry picked from commit ad3c99e)

Co-authored-by: Guy Yagev <[email protected]>
Co-authored-by: Shantanu <[email protected]>
This was referenced Dec 26, 2022
Argparse choices should be a sequence #92446
Closed
gh-92446: Fix Argparse and LZMACompressor Docs #94627
Merged
@bedevere-bot bedevere-bot added skip news awaiting core review docs Documentation in the Doc dir labels Dec 26, 2022
@hauntsaninja
hauntsaninja merged commit a167365 into python:3.10 Dec 26, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Dec 26, 2022
@hauntsaninja
hauntsaninja deleted the backport-ad3c99e-3.10 branch December 26, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hauntsaninja @bedevere-bot @yourlefthandman
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.