GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-100538: Create a workflow for verifying bundled libexpat files by illia-v · Pull Request #100539 · python/cpython

Conversation

@illia-v

@illia-v illia-v commented Dec 26, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Tags of libexpat releases are signed and GitHub runs a verification process on them.

I added a check of the verification status retrieved via GitHub's API. If the check succeeds, the script downloads a release source code and compares content of bundled files to the source.

Since a few lines are added to Modules/expat/expat_external.h, I moved them to the top of the file and the script skips them.

  • Issue: Create a GitHub Actions workflow for verifying bundled libexpat files #100538

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@illia-v
pythongh-100538: Create a workflow for verifying bundled libexpat files
aa6bada
@illia-v
illia-v requested a review from ezio-melotti as a code owner December 26, 2022 19:34
@bedevere-bot bedevere-bot mentioned this pull request Dec 26, 2022
Create a GitHub Actions workflow for verifying bundled libexpat files #100538
Closed
@bedevere-bot bedevere-bot added the awaiting review label Dec 26, 2022
@sobolevn sobolevn added the skip news label Dec 27, 2022
@sobolevn

sobolevn commented Dec 27, 2022

Copy link
Copy Markdown
Member

You don't need news for build tools :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
illia-v added 2 commits February 3, 2023 15:48
@illia-v
Merge branch 'main' into verify-expat
3708b93
@illia-v
Remove a news entry
08232f8
@illia-v

illia-v commented Feb 3, 2023

Copy link
Copy Markdown
Contributor Author

@sobolevn I removed the news entry
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hartwork hartwork mentioned this pull request Feb 14, 2024
gh-115399: Upgrade bundled libexpat to 2.6.0 #115431
Merged
@StanFromIreland
Merge branch 'main' into verify-expat
6e2ae57
@StanFromIreland
StanFromIreland requested review from AA-Turner and hugovk as code owners August 17, 2025 17:06
@StanFromIreland
StanFromIreland requested a review from sethmlarson October 4, 2025 07:19
picnixz
picnixz reviewed Oct 4, 2025
View reviewed changes
Comment thread Modules/expat/expat_external.h
@@ -1,3 +1,7 @@
/* Namespace external symbols to allow multiple libexpat version to

@picnixz picnixz Oct 4, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is should not be needed. It's already included below.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz

picnixz commented Oct 4, 2025

Copy link
Copy Markdown
Member

More generally, I'm not sure we actually need this step. Aren't we already doing this with SBOM checks?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland

StanFromIreland commented Feb 28, 2026

Copy link
Copy Markdown
Member

Aren't we already doing this with SBOM checks?

We aren't verifying that the files in the repository are the same as the ones in the release.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland StanFromIreland mentioned this pull request Feb 28, 2026
gh-100538: Add workflow to verify bundled libexpat #145359
Merged
@StanFromIreland

StanFromIreland commented Feb 28, 2026

Copy link
Copy Markdown
Member

I propose a simpler alternative: #145359
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead

gpshead commented Mar 1, 2026

Copy link
Copy Markdown
Member

closing as the alternative PR merged. thanks though, this is a useful thing for us to have!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead closed this Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@sethmlarson sethmlarson Awaiting requested review from sethmlarson

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@illia-v @sobolevn @picnixz @StanFromIreland @gpshead @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.