GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-100126: Skip incomplete frames in more places by brandtbucher · Pull Request #100613 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Dec 30, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Also, add two new internal APIs (_PyFrame_GetComplete and _PyThreadState_GetFrame) to make this common move a bit cleaner.

  • Issue: Shim frames can be accessed during frame teardown (via tstate->cframe->current_frame) #100126

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brandtbucher added 5 commits December 29, 2022 04:40
@brandtbucher
Add a failing regression test
5f18200
@brandtbucher
fixup
4ff833e
@brandtbucher
Add _PyFrame_GetComplete/_PyThreadState_GetFrame
04b77ac
@brandtbucher
Clean up how we access/walk the frame stack
41c70e6
@brandtbucher
blurb add
53d066e
@brandtbucher brandtbucher added interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker type-crash A hard crash of the interpreter, possibly with a core dump labels Dec 30, 2022
@brandtbucher
brandtbucher requested a review from markshannon as a code owner December 30, 2022 02:54
@brandtbucher brandtbucher self-assigned this Dec 30, 2022
@bedevere-bot bedevere-bot mentioned this pull request Dec 30, 2022
Shim frames can be accessed during frame teardown (via tstate->cframe->current_frame) #100126
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Dec 30, 2022
@brandtbucher brandtbucher added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 30, 2022
@bedevere-bot

bedevere-bot commented Dec 30, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit 53d066e 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 30, 2022
@brandtbucher

brandtbucher commented Dec 30, 2022

Copy link
Copy Markdown
Member Author

The one failing buildbot (ARM64 Windows) has been failing on other PRs too.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
markshannon
markshannon reviewed Jan 5, 2023
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quibble about naming.

Looks good. Hopefully this is the last of the frame stack traversal issues.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Include/internal/pycore_frame.h Outdated
}

static inline _PyInterpreterFrame *
_PyFrame_GetComplete(_PyInterpreterFrame *frame)

@markshannon markshannon Jan 5, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name gives no sense of traversing the stack until a complete frame is found.
Maybe _PyFrame_GetFirstComplete()?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brandtbucher reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
brandtbucher added 2 commits January 9, 2023 11:17
@brandtbucher
Catch up with main
eea02f9
@brandtbucher
_PyFrame_GetComplete -> _PyFrame_GetFirstComplete
3c8830b
@brandtbucher
brandtbucher merged commit 61762b9 into python:main Jan 9, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 9, 2023
@A5rocks A5rocks mentioned this pull request Jan 10, 2023
New Python versions for CI python-trio/trio#2514
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@brandtbucher @bedevere-bot @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.