GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||
GeezerVison is showing github.com — gh-89727: Improve os.walk complexity and speed by zmievsa · Pull Request #100671 · python/cpython Conversation…:ovsyanka83/cpython into pythongh-89727/minor-os-walk-refactoring
|
There was an error while loading. Please reload this page.
|
@JelleZijlstra I can't assign a reviewer but you merged the prior PR related to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Do you have a benchmark that shows this actually makes it faster? We lose a tuple allocation but gain a function call, so it's not completely obvious this should be faster. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…edHN.rst Co-authored-by: Jelle Zijlstra <[email protected]>
There was an error while loading. Please reload this page.
|
I made this MR because my initial benchmarking with Seems like the isinstance version is just a tiny bit (insignificantly) faster but I would still argue that it makes more sense than the original because it is slightly simpler. But what do you think? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks, seems like it's about a wash but since the new code is simpler and we never released the old version, seems fine to change this. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.