GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-100428: Make int documentation more accurate (GH-100436) by miss-islington · Pull Request #100674 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 2, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Remove first link to lexical definition of integer literal, since it
    doesn't apply (differs in handling of leading zeros, base needs to be
    explicitly specified, unicode digits are allowed)
  • Better describe handling of leading zeros, unicode digits, underscores
  • Base 0 does not work exactly as like a code literal, since it allows
    Unicode digits. Link code literal to lexical definition of integer
    literal.
    (cherry picked from commit edfbf56)

Co-authored-by: Shantanu [email protected]

  • Issue: Float documentation doesn't allow int-like strings as valid arguments for float #100428

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hauntsaninja @miss-islington
pythongh-100428: Make int documentation more accurate (pythonGH-100436)
73163a1
- Remove first link to lexical definition of integer literal, since it
  doesn't apply (differs in handling of leading zeros, base needs to be
  explicitly specified, unicode digits are allowed)
- Better describe handling of leading zeros, unicode digits, underscores
- Base 0 does not work exactly as like a code literal, since it allows
  Unicode digits. Link code literal to lexical definition of integer
  literal.
(cherry picked from commit edfbf56)

Co-authored-by: Shantanu <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label Jan 2, 2023
This was referenced Jan 2, 2023
Float documentation doesn't allow int-like strings as valid arguments for float #100428
Closed
gh-100428: Make int documentation more accurate #100436
Merged
@bedevere-bot bedevere-bot added skip news docs Documentation in the Doc dir labels Jan 2, 2023
hauntsaninja
hauntsaninja approved these changes Jan 2, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jan 2, 2023
@miss-islington
miss-islington merged commit af136e9 into python:3.11 Jan 2, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 2, 2023
@miss-islington
miss-islington deleted the backport-edfbf56-3.11 branch January 2, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @hauntsaninja @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.