GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-100485: Add math.sumprod() by rhettinger · Pull Request #100677 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented Jan 2, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Consider adding sumproduct() or dotproduct() to the math module #100485

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
rhettinger added 9 commits January 1, 2023 17:29
@rhettinger
Stub function.
5776b0f
@rhettinger
Core fuctionality without error handling
8ffd49e
@rhettinger
Test core functionality.
f5a3ecb
@rhettinger
Add docs
37fcb0a
@rhettinger
Check for non-iterable inputs
6cfc5cc
@rhettinger
Handle uneven lengths and error returns from PyIter_Next().
fbeca6b
@rhettinger
Handle errors arising during the multiplications or additions.
40cfc8f
@rhettinger
Test special values
2ac24f5
@rhettinger
Add blurb
1a64fd8
@rhettinger rhettinger added type-feature A feature request or enhancement 3.12 only security fixes labels Jan 2, 2023
@rhettinger
rhettinger requested a review from tim-one January 2, 2023 03:59
@bedevere-bot bedevere-bot added the awaiting core review label Jan 2, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 2, 2023
Consider adding sumproduct() or dotproduct() to the math module #100485
Closed
@rhettinger
Regenerate clinic files
5f4e493
@rhettinger rhettinger added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 2, 2023
@bedevere-bot

bedevere-bot commented Jan 2, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 5f4e493 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 2, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 5f4e493 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 2, 2023
rhettinger added 9 commits January 3, 2023 11:32
@rhettinger
Beautify with booleans.
31fa258
@rhettinger
Add int_path. Needs work on refcount and addition overflow.
d19a38b
@rhettinger
Add more assertions and refcount fixes
a28fd71
@rhettinger
Only test for ints when iterators are not stopped.
f998ee4
@rhettinger
Test long addition for overflow
94a9cbd
@rhettinger
Improve wording regarding extended precision.
c778865
@rhettinger
Add the "finished" summary variable for readability.
6d619dd
@rhettinger
Add flt path
83dbf96
@rhettinger
add flt/int path
c2e5f3d
rhettinger added 9 commits January 4, 2023 22:26
@rhettinger
Fully encapsulate the dl (double length) logic.
9b03468
@rhettinger
Add performance comment.
8b88f4d
@rhettinger
Write tight.
83ca929
@rhettinger
Abbreviate comment.
708f314
@rhettinger
Remove case for int/int while float in use.
90f1ee4
@rhettinger
Beautify dl_add()
02035dc
@rhettinger
Add stress tests.
9b1edcc
@rhettinger
Update itertools recipe to reflect the promotion.
22249d6
@rhettinger
Remove doctest for dotproduct().
ec50404
@rhettinger rhettinger added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 5, 2023
@bedevere-bot

bedevere-bot commented Jan 5, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit ec50404 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 5, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit ec50404 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 5, 2023
rhettinger added 7 commits January 6, 2023 09:43
@rhettinger
Speed-up iterator access. Let float be selected by bools.
19dfd08
@rhettinger
Add assertion for a key checkpoint
13f1d4f
@rhettinger
Move dl_mul() out to a separate function. Dekker (5.8).
a07e03d
@rhettinger
Add the smaller magnitude component first.
d274325
@rhettinger
Use Dekker (5.12) directly. Avoids calling dl_add() and saves a compa…
67f82ca 
…rison.
@rhettinger
Update timing in comment.
5d165be
@rhettinger
Add in the large component first.
2e772cb
@rhettinger rhettinger added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 7, 2023
@bedevere-bot

bedevere-bot commented Jan 7, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 2e772cb 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 7, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit 2e772cb 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jan 7, 2023
@rhettinger
rhettinger merged commit 47b9f83 into python:main Jan 7, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tim-one tim-one Awaiting requested review from tim-one

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.12 only security fixes type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rhettinger @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.