GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-98831: Add some tests for generate_cases.py by gvanrossum · Pull Request #100763 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Jan 5, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • This doesn't cover everything (far from it) but it's a start.
  • This uses pytest, which isn't ideal, but was quickest to get started.
  • Issue: Generate the interpreter #98831

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum gvanrossum added the skip news label Jan 5, 2023
@gvanrossum
gvanrossum requested a review from iritkatriel January 5, 2023 00:11
@bedevere-bot bedevere-bot added the awaiting core review label Jan 5, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 5, 2023
Generate the interpreter #98831
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jan 5, 2023
kumaraditya303
kumaraditya303 reviewed Jan 5, 2023
View reviewed changes
Comment thread Tools/cases_generator/test_generator.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel reviewed Jan 5, 2023
View reviewed changes
Comment thread Tools/cases_generator/test_generator.py Outdated
import generate_cases


def run_test(input: str, expected: str):

@iritkatriel iritkatriel Jan 5, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe run_cases_test, because we will also have a run_metadata test?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Tools/cases_generator/test_generator.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum and others added 3 commits January 5, 2023 14:09
@gvanrossum
Add some tests for generate_cases.py
01881a4 
- This doesn't cover everything (far from it) but it's a start.
- This uses pytest, which isn't ideal, but was quickest to get started.
@gvanrossum
Rename run_test() to run_cases_test()
f422ea9 
In anticipation of run_opcode_test().
@gvanrossum @kumaraditya303
Fix f-string
e06aa07 
Co-authored-by: Kumar Aditya <[email protected]>
@gvanrossum
gvanrossum force-pushed the cases-test branch from a73c227 to e06aa07 Compare January 5, 2023 22:11
@gvanrossum

gvanrossum commented Jan 5, 2023

Copy link
Copy Markdown
Member Author

Ready for review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel approved these changes Jan 6, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 6, 2023
@gvanrossum
gvanrossum merged commit 9ffbc58 into python:main Jan 6, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 6, 2023
@gvanrossum
gvanrossum deleted the cases-test branch January 6, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments
@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@gvanrossum @iritkatriel @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.