GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-99005: Add `CALL_INTRINSIC_1` instruction by markshannon · Pull Request #100771 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Jan 5, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add CALL_INTRINSIC instruction. #99005

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
markshannon added 6 commits January 5, 2023 12:35
@markshannon
Add CALL_INSTRINSIC_1 instruction, but don't use it yet.
4e1e4a3
@markshannon
Remove PRINT_EXPR instruction, replacing it with CALL_INTRINSIC_1.
f0eafa9
@markshannon
Remove STOPITERATION_ERROR instruction, replacing it with CALL_INTRIN…
8510861 
…SIC_1
@markshannon
Remove IMPORT_STAR instruction, replacing it with CALL_INTRINSIC_1
6e99cc7
@markshannon
Add news and update dis docs.
66d3ea4
@markshannon
Fix issue number.
fcf2806
@markshannon
markshannon requested review from a team and iritkatriel as code owners January 5, 2023 14:04
@bedevere-bot bedevere-bot added the awaiting core review label Jan 5, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 5, 2023
Add CALL_INTRINSIC instruction. #99005
Closed
markshannon added 3 commits January 5, 2023 14:08
@markshannon
Merge branch 'main' into intrinsics
ed870bb
@markshannon
Fix typo in project file.
9c6cbbc
@markshannon
Tidy up formatting.
c5ecb5f
@markshannon
markshannon requested a review from brandtbucher January 5, 2023 14:25
iritkatriel
iritkatriel reviewed Jan 5, 2023
View reviewed changes
Comment thread Python/intrinsics.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel approved these changes Jan 5, 2023
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is cool.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 5, 2023
iritkatriel
iritkatriel reviewed Jan 5, 2023
View reviewed changes
Comment thread Doc/library/dis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel reviewed Jan 5, 2023
View reviewed changes
Comment thread Lib/importlib/_bootstrap_external.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel reviewed Jan 5, 2023
View reviewed changes
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
markshannon and others added 5 commits January 5, 2023 15:01
@markshannon
Make error code checking consistent.
8bad358
@markshannon
Make CALL_INTRINSIC_1 a bit more robust
a39ac2b
@markshannon
Document the operand of CALL_INTRINSIC_1
a0a4ba6
@markshannon @iritkatriel
Update Lib/importlib/_bootstrap_external.py
e42c99d 
Co-authored-by: Irit Katriel <[email protected]>
@markshannon
Update generated_cases.c.h
abb24b9
@markshannon
markshannon merged commit 2818714 into python:main Jan 5, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 5, 2023
@markshannon
markshannon deleted the intrinsics branch September 26, 2023 12:53
@gouzil gouzil mentioned this pull request Feb 22, 2024
[SOT][3.12] Support CALL_INTRINSIC_1 opcode in Python 3.12 PaddlePaddle/Paddle#61995
Merged
@ShaharNaveh ShaharNaveh mentioned this pull request Dec 2, 2025
Move PrintExpr to IntristicFunction1 RustPython/RustPython#6324
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markshannon @iritkatriel @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.