GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-98831: Revert "GH-98831: Update generate_cases.py: register inst, opcode_metadata.h (#100735)" by gvanrossum · Pull Request #100777 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Jan 5, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

That commit broke the build, I think something was stale.

This reverts commit 14b7f00.

  • Issue: Generate the interpreter #98831

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum
Revert "pythonGH-98831: Update generate_cases.py: register inst, opco…
8e04e2f 
…de_metadata.h (python#100735)"

That commit broke the build, I think something was stale.

This reverts commit 14b7f00.
@gvanrossum
gvanrossum requested review from iritkatriel and markshannon as code owners January 5, 2023 21:09
@bedevere-bot bedevere-bot added the awaiting core review label Jan 5, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 5, 2023
Generate the interpreter #98831
Closed
@gvanrossum gvanrossum mentioned this pull request Jan 5, 2023
GH-98831: Update generate_cases.py: register inst, opcode_metadata.h #100735
Merged
@gvanrossum gvanrossum added the skip news label Jan 5, 2023
carljm
carljm approved these changes Jan 5, 2023
View reviewed changes
@merwok

merwok commented Jan 5, 2023

Copy link
Copy Markdown
Member

see #100778 for a fix instead!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented Jan 5, 2023

Copy link
Copy Markdown
Member Author

Closing in favor of #100778.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum gvanrossum closed this Jan 5, 2023
@gvanrossum
gvanrossum deleted the revert-100735 branch January 5, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@gvanrossum @merwok @carljm @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.