GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] Clarify re docs for byte pattern group names (GH-99308) by Kentzo · Pull Request #101001 · python/cpython

Conversation

@Kentzo

@Kentzo Kentzo commented Jan 12, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Cryptic deprecation notice in the re module #99308

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Kentzo
pythongh-99308: Fix wording of the deprecation notice in re for 3.11
7b84a3d
@bedevere-bot bedevere-bot added the awaiting review label Jan 12, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 12, 2023
Cryptic deprecation notice in the re module #99308
Closed
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Jan 12, 2023
@slateny

slateny commented Jan 14, 2023

Copy link
Copy Markdown
Contributor

Per comment I don't believe there should be a backport for this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Kentzo

Kentzo commented Jan 14, 2023

Copy link
Copy Markdown
Contributor Author

#99308 (comment) says otherwise
slateny and CAM-Gerlach reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CAM-Gerlach
CAM-Gerlach reviewed Jan 14, 2023
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kentzo . One set of suggestions, otherwise LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/re.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/re.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/re.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@CAM-Gerlach
CAM-Gerlach requested a review from hauntsaninja January 14, 2023 04:09
hauntsaninja
hauntsaninja approved these changes Jan 17, 2023
View reviewed changes

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting this!

Looks like it's common enough for past versions of docs to contain "removed" for future versions of Python, so would you mind applying CAM's suggestions?

Edit: Since this has been lying around, I think this is fine to merge as is without the more specific directives; 3.12 isn't finalised and this seems like a short time between deprecation and removal.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
CAM-Gerlach reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jan 17, 2023
@hauntsaninja
hauntsaninja merged commit cda1d52 into python:3.11 Mar 4, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments
@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Kentzo @slateny @hauntsaninja @CAM-Gerlach @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.