GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-98831: Move assorted macros from ceval.h to a new header by gvanrossum · Pull Request #101116 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Jan 18, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reduces the dummy setup in bytecodes.c.

Also add some missing dummy definitions to the latter.

Should be simple to review. :-)

  • Issue: Generate the interpreter #98831

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum
Move assorted macros from ceval.h to a new header
b315757 
This reduces the dummy setup in bytecodes.c.

Also add some missing dummy definitions to the latter.
@gvanrossum gvanrossum added the skip news label Jan 18, 2023
@gvanrossum
gvanrossum requested review from brandtbucher and markshannon January 18, 2023 04:03
@bedevere-bot bedevere-bot added the awaiting core review label Jan 18, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 18, 2023
Generate the interpreter #98831
Closed
gvanrossum added 2 commits January 17, 2023 20:13
@gvanrossum
Add ceval.c deps to Makefile.pre.in
7ca33e6
@gvanrossum
Tweak dummy stuff a bit more
b1e58d4
brandtbucher
brandtbucher approved these changes Jan 18, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 18, 2023
@gvanrossum
gvanrossum merged commit 1f0d0a4 into python:main Jan 18, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 18, 2023
@gvanrossum
gvanrossum deleted the cases-macros branch January 18, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gvanrossum @brandtbucher @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.