GeezerVison is showing github.com — GH-101112: Specify type of pattern for Path.rglob by jugmac00 · Pull Request #101132 · python/cpython
Conversation
jugmac00
commented
Jan 18, 2023
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
The documentation for rglob did not mention what pattern actually is.
Mentioning and linking to fnmatch makes this explicit, as the documentation for fnmatch both shows the syntax and some explanation.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The documentation for `rglob` did not mention what `pattern` actually
is.
Mentioning and linking to `fnmatch` makes this explicit, as the
documentation for `fnmatch` both shows the syntax and some explanation.
|
Thanks @jugmac00 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Sorry, @jugmac00 and @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 61f338a005aa9f36b2a0a8d6924857e703bb6140 3.11
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Sorry @jugmac00 and @ambv, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 61f338a005aa9f36b2a0a8d6924857e703bb6140 3.10
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@ambv my fault, I should have converted this pr into a draft after I received some valuable feedback on the related issue. While the merged content is not 100% correct, imho it is not that bad. I will prepare a follow-up pr tomorrow.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Oh, it wasn't clear to me the suggestions are meant to be part of this PR. Yeah, a follow up will be great, thanks.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
barneygale reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
barneygale
Awaiting requested review from barneygale
barneygale is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|