GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98831: register instructions have 0 pushes and pops by iritkatriel · Pull Request #101163 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jan 19, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Generate the interpreter #98831

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-98831: register instructions have 0 pushes and pops
2c7a950
@iritkatriel
iritkatriel requested a review from gvanrossum January 19, 2023 19:58
@bedevere-bot bedevere-bot added the awaiting core review label Jan 19, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 19, 2023
Generate the interpreter #98831
Closed
gvanrossum
gvanrossum approved these changes Jan 19, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

Maybe it's time to add some tests for the generated opcode metadata (but I'm not asking for that now).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 19, 2023
@gvanrossum gvanrossum added the skip news label Jan 19, 2023
@iritkatriel

iritkatriel commented Jan 19, 2023

Copy link
Copy Markdown
Member Author

It failed very quickly when I tried to use it (the sanity check we added in the compiler flipped).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented Jan 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Is it ready to merge?

Note: there are other things in the generator that probably don't work, e.g. there are some commented-out out.emit(f"JUMPBY(OPSIZE(... calls. But those might be not needed if we go ahead with the variable-length scheme.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented Jan 19, 2023

Copy link
Copy Markdown
Member Author

Is it ready to merge?

I think so.

Note: there are other things in the generator that probably don't work, e.g. there are some commented-out out.emit(f"JUMPBY(OPSIZE(... calls. But those might be not needed if we go ahead with the variable-length scheme.

I'm not doing variable length instructions now. I'm adding the plumbing in the compiler, and for now supporting only 1 oparg (so I can do RETURN_VALUE from a tmp register). There's plenty there to keep me busy for now.
gvanrossum reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit 8a2d4f4 into python:main Jan 19, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @gvanrossum @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.