GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-59956: Allow the "Trashcan" Mechanism to Work Without a Thread State by ericsnowcurrently · Pull Request #101209 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Jan 21, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We've factored out a struct from the two PyThreadState fields. This accomplishes two things:

  • make it clear that the trashcan-related code doesn't need any other parts of PyThreadState
  • allows us to use the trashcan mechanism even when there isn't a "current" thread state

We still expect the caller to hold the GIL.

  • Issue: [subinterpreters] Make the PyGILState API compatible with subinterpreters #59956

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 2 commits January 20, 2023 17:33
@ericsnowcurrently
Factor out struct _py_trashcan.
5be85dc
@ericsnowcurrently
Fall back to a thread-local when there is not current tstate.
50288a1
@ericsnowcurrently ericsnowcurrently added the skip news label Jan 21, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jan 21, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 21, 2023
[subinterpreters] Make the PyGILState API compatible with subinterpreters #59956
Open
@ericsnowcurrently
ericsnowcurrently merged commit 7b20a0f into python:main Jan 23, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 23, 2023
@ericsnowcurrently
ericsnowcurrently deleted the trashcan-struct branch January 23, 2023 15:30
@tacaswell tacaswell mentioned this pull request Apr 3, 2023
Fix #323: Support Python 3.12 python-greenlet/greenlet#327
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.