GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98831: rewrite CHECK_EG_MATCH opcode in the instruction definition DSL by iritkatriel · Pull Request #101269 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jan 23, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The change in exception_group_match is needed because previously in the case of match == None the opcode didn't look at rest, but now it pushes to the stack (even though it's already there) to keep the code uniform with the match != None case.

  • Issue: Generate the interpreter #98831

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iritkatriel added 2 commits January 23, 2023 22:03
@iritkatriel
pythongh-98831: Modernize CHECK_EG_MATCH
ed436dc
@iritkatriel
Add news
48d0fcb
@iritkatriel
iritkatriel requested a review from gvanrossum January 23, 2023 22:09
@iritkatriel
iritkatriel requested a review from markshannon as a code owner January 23, 2023 22:09
@bedevere-bot bedevere-bot added the awaiting core review label Jan 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 23, 2023
Generate the interpreter #98831
Closed
@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Jan 23, 2023
gvanrossum
gvanrossum approved these changes Jan 23, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this one wasn't trivial. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jan 23, 2023
gvanrossum
gvanrossum reviewed Jan 23, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2023-01-23-22-06-07.gh-issue-98831.FkCDuV.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
Revert "Add news"
93d98ab 
This reverts commit 48d0fcb.
@iritkatriel iritkatriel added the skip news label Jan 23, 2023
@iritkatriel

iritkatriel commented Jan 23, 2023

Copy link
Copy Markdown
Member Author

I'll kick off the buildbots in case refcount.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2023
@bedevere-bot

bedevere-bot commented Jan 23, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 93d98ab 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jan 23, 2023
@gvanrossum

gvanrossum commented Jan 24, 2023

Copy link
Copy Markdown
Member

PPC64 Fedora PR is failing with "No space left on device", so I wouldn't worry about that one. :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit 8c183cd into python:main Jan 24, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 24, 2023
@iritkatriel
iritkatriel deleted the CHECK_EG_MATCH branch April 3, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @bedevere-bot @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.