GeezerVison is showing github.com — [docs] gh-101273: Expand enum documentation on limitations by samypr100 · Pull Request #101274 · python/cpython
Conversation
samypr100
commented
Jan 23, 2023
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this needs to be in the docs; I am sure that this is not the right section for them to be in. I'll try to review the enum docs this week to see if there is a better spot for this warning.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
samypr100 and AlexWaygood reacted with thumbs up emoji
|
@ethanfurman To expand a little on the motivation, the codebase that I originally encountered this had something close to
class ElementType(StrEnum):
title = "..."
comment = "..."
author = "..."
# ...
It didn't occur to me at first that the errors I was seeing in mypy (mypy was being added after the fact) were due to StrEnum inheriting from str, hence why I also thought that it might be a good idea to add a warning/note to the docs.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
Closing in favor of #103596. Thank you, @samypr100 for the encouragement to properly fix this behavior.
|
samypr100 reacted with rocket emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Expand on enum limitations
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.