GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [docs] gh-101273: Expand enum documentation on limitations by samypr100 · Pull Request #101274 · python/cpython

Conversation

@samypr100

@samypr100 samypr100 commented Jan 23, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Closes #101273

  • Issue: Expand on enum limitations #101273

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@samypr100
samypr100 requested a review from ethanfurman as a code owner January 23, 2023 23:16
@bedevere-bot bedevere-bot added the awaiting review label Jan 23, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 23, 2023
Expand on enum limitations #101273
Closed
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jan 23, 2023
@samypr100
samypr100 force-pushed the enum-docs-update branch from 2719ecb to 1bbd095 Compare January 23, 2023 23:19
ethanfurman
ethanfurman reviewed Jan 24, 2023
View reviewed changes

@ethanfurman ethanfurman left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this needs to be in the docs; I am sure that this is not the right section for them to be in. I'll try to review the enum docs this week to see if there is a better spot for this warning.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

samypr100 and AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@samypr100

samypr100 commented Jan 24, 2023

Copy link
Copy Markdown
Contributor Author

@ethanfurman To expand a little on the motivation, the codebase that I originally encountered this had something close to

class ElementType(StrEnum):
    title = "..."
    comment = "..."
    author = "..."
    # ...

It didn't occur to me at first that the errors I was seeing in mypy (mypy was being added after the fact) were due to StrEnum inheriting from str, hence why I also thought that it might be a good idea to add a warning/note to the docs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sobolevn
sobolevn reviewed Jan 24, 2023
View reviewed changes
Comment thread Misc/NEWS.d/next/Documentation/2023-01-23-17-55-15.gh-issue-101273.Ae-Hed.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/enum.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/enum.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/enum.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@samypr100
Expand enum documentation to include additional limitations when shad…
afde363
…owing a built-in
@samypr100
samypr100 force-pushed the enum-docs-update branch from 1bbd095 to afde363 Compare January 25, 2023 01:26
@ethanfurman ethanfurman added the skip news label Jan 25, 2023
@python python deleted a comment from bedevere-bot Jan 25, 2023
@ethanfurman

ethanfurman commented Apr 17, 2023

Copy link
Copy Markdown
Member

Closing in favor of #103596. Thank you, @samypr100 for the encouragement to properly fix this behavior.

samypr100 reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ethanfurman ethanfurman closed this Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments
@ethanfurman ethanfurman ethanfurman left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expand on enum limitations

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@samypr100 @ethanfurman @sobolevn @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.