GeezerVison is showing github.com — [3.11] GH-100762: Don't call gen.throw() in gen.close(), unless necessary by markshannon · Pull Request #101316 · python/cpython
Conversation
markshannon
commented
Jan 25, 2023
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
This a backport of #101013 in principle, although the mechanism for determining when to skip the call to throw() is different.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
markshannon
changed the title
[3.11] Don't call gen.throw() in gen.close(), unless necessary
[3.11] GH-100762: Don't call gen.throw() in gen.close(), unless necessary
Jan 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still want to do this? The code looks fine to me... I'm not sure why the tests are failing, but it definitely seems related.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Given 3.13 will be released soon and this is working in 3.12, I don't think it is worth investigating further why this doesn't work.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
1st1
Awaiting requested review from 1st1
1st1 is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.