GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101322: Ensure test_zlib.ZlibDecompressorTest runs, fix errors in ZlibDecompressor by rhpvorderman · Pull Request #101323 · python/cpython

Conversation

@rhpvorderman

@rhpvorderman rhpvorderman commented Jan 25, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Turns out that when I made #97664 I added test but these are actually not run at test time.

I also found a small error in the code that is now fixed.

  • Issue: ZlibDecompressor not tested #101322

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rhpvorderman
Ensure test_zlib.ZlibDecompressorTest actually runs, fix errors in Zl…
48e6483 
…ibDecompressor
@bedevere-bot bedevere-bot added the awaiting review label Jan 25, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 25, 2023
ZlibDecompressor not tested #101322
Closed
@rhpvorderman
Add blurb for _ZlibDecompressor error fix
e4b342b
kumaraditya303
kumaraditya303 approved these changes Feb 3, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 3, 2023
@kumaraditya303
kumaraditya303 requested a review from gpshead February 3, 2023 17:24
gpshead
gpshead approved these changes Feb 4, 2023
View reviewed changes
@gpshead
gpshead merged commit a89e671 into python:main Feb 4, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 4, 2023
@rhpvorderman

rhpvorderman commented Feb 6, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rhpvorderman
rhpvorderman deleted the testfix branch February 6, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@rhpvorderman @gpshead @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.