GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-71966: Sync-up docstrings in C version of the the decimal module by furkanonder · Pull Request #101350 · python/cpython

Conversation

@furkanonder

@furkanonder furkanonder commented Jan 26, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Sync-up docstrings in C version of the the decimal module #71966

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
furkanonder added 3 commits January 26, 2023 20:28
@furkanonder
Sync-up docstrings in C version of the the decimal module
7aceaf1
@furkanonder
Revert "Sync-up docstrings in C version of the the decimal module"
8818ee9 
This reverts commit 7aceaf1.
@furkanonder
Sync-up docstrings in C version of the the decimal module
e15cd0e
@furkanonder
furkanonder requested a review from rhettinger as a code owner January 26, 2023 17:33
@bedevere-bot bedevere-bot added the awaiting review label Jan 26, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 26, 2023
Sync-up docstrings in C version of the the decimal module #71966
Open
furkanonder added 2 commits January 26, 2023 17:33
@furkanonder
Merge branch 'main' into issue-71966
1559993
@furkanonder
add missing docstrings
23ce0e9
@rhettinger rhettinger self-assigned this Jan 27, 2023
@rhettinger rhettinger added the skip news label Jan 27, 2023
furkanonder added 7 commits January 27, 2023 17:07
@furkanonder
refactor docs
3620c33
@furkanonder
refactor docs
30dd2b3
@furkanonder
fix quantize
9618e9e
@furkanonder
Update docstrings.h
723f718
@furkanonder
fix quantize's doc
ad50aa0
@furkanonder
Merge branch 'main' into issue-71966
62842fc
@furkanonder
Merge branch 'main' into issue-71966
e23532b
@furkanonder furkanonder changed the title GH-71966: Sync-up docstrings in C version of the the decimal module gh-71966: Sync-up docstrings in C version of the the decimal module Aug 6, 2023
@serhiy-storchaka
serhiy-storchaka requested a review from mdickinson January 16, 2024 14:22
serhiy-storchaka
serhiy-storchaka reviewed Jan 16, 2024
View reviewed changes
Comment thread Modules/_decimal/docstrings.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/_pydecimal.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/_pydecimal.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_decimal/docstrings.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_decimal/docstrings.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka requested a review from lisroach February 27, 2024 13:22
erlend-aasland
erlend-aasland reviewed Mar 3, 2024
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the imperative mood consistently for reference text.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
furkanonder reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Lib/_pydecimal.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_decimal/docstrings.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_decimal/docstrings.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_decimal/docstrings.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_decimal/docstrings.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_decimal/docstrings.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_decimal/docstrings.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_decimal/docstrings.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_decimal/docstrings.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_decimal/docstrings.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
furkanonder and others added 8 commits April 15, 2024 21:40
@furkanonder @erlend-aasland
Use the imperative mood
7ec70fb 
Co-authored-by: Erlend E. Aasland <[email protected]>
@furkanonder @erlend-aasland
Use the imperative mood
5596afd 
Co-authored-by: Erlend E. Aasland <[email protected]>
@furkanonder @erlend-aasland
Use the imperative mood
d76c6dc 
Co-authored-by: Erlend E. Aasland <[email protected]>
@furkanonder @erlend-aasland
Use the imperative mood
320d6b7 
Co-authored-by: Erlend E. Aasland <[email protected]>
@furkanonder @erlend-aasland
Use the imperative mood
35907ac 
Co-authored-by: Erlend E. Aasland <[email protected]>
@furkanonder @erlend-aasland
Use the imperative mood
84ad628 
Co-authored-by: Erlend E. Aasland <[email protected]>
@furkanonder @erlend-aasland
Use the imperative mood
77d6ea7 
Co-authored-by: Erlend E. Aasland <[email protected]>
@furkanonder @erlend-aasland
Use the imperative mood
d5c81c1 
Co-authored-by: Erlend E. Aasland <[email protected]>
furkanonder and others added 24 commits April 16, 2024 01:51
@furkanonder
Sync-up docstring for canonical function
c067c35
@furkanonder
Sync-up docstring for compare_signal function
f117498
@furkanonder
Sync-up docstring for compare_total function
b1c5f94
@furkanonder
Sync-up docstring for conjugate function
a283af7
@furkanonder
Sync-up docstring for logical_and function
d4eae92
@furkanonder
Sync-up docstring for logical_invert function
1fd52d2
@furkanonder
Sync-up docstring for logical_or function
5c4ce3c
@furkanonder
Sync-up docstring for logical_xor function
8786c92
@furkanonder
Sync-up docstring for max function
c1d87e0
@furkanonder
Sync-up docstring for max_mag function
6b13483
@furkanonder
Sync-up docstring for min function
cdeac33
@furkanonder
Sync-up docstring for min_mag function
45be158
@furkanonder
Sync-up docstring for next_minus function
0354723
@furkanonder
Sync-up docstring for quantize function
0fd9ee4
@furkanonder
Sync-up docstring for fma function
50595fa
@furkanonder @erlend-aasland
Use the imperative mood
1c8b9fd 
Co-authored-by: Erlend E. Aasland <[email protected]>
@furkanonder
Merge branch 'main' into issue-71966
334abe0
@furkanonder @erlend-aasland
Use the imperative mood
ff0c52c 
Co-authored-by: Erlend E. Aasland <[email protected]>
@furkanonder
Use the imperative mood
1b34403
@furkanonder @erlend-aasland
Use the imperative mood
b8aa470 
Co-authored-by: Erlend E. Aasland <[email protected]>
@furkanonder
Sync-up docstring for max function
2af51d2
@furkanonder
Sync-up docstring for logical_xor, rotate and same_quantum function
c67ca48
@furkanonder
Sync-up docstring for min function
3302858
@furkanonder
Merge branch 'main' into issue-71966
d92ac62
@mdickinson
mdickinson removed their request for review May 14, 2024 07:30
@skirpichev

skirpichev commented Oct 19, 2025

Copy link
Copy Markdown
Member

@furkanonder, this now has merge conflicts. Are you interested to resolve them?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@furkanonder

furkanonder commented Oct 30, 2025

Copy link
Copy Markdown
Contributor Author

@furkanonder, this now has merge conflicts. Are you interested to resolve them?

Thanks for letting me know! I’ll take care of the merge conflicts and update the PR soon.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev

skirpichev commented Oct 30, 2025

Copy link
Copy Markdown
Member

But please first take look on the issue thread. Maybe manual synchronization is not what we want here in a long term.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Apr 12, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@erlend-aasland erlend-aasland erlend-aasland left review comments
@rhettinger rhettinger Awaiting requested review from rhettinger
@lisroach lisroach Awaiting requested review from lisroach

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rhettinger rhettinger

Labels

awaiting review skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@furkanonder @skirpichev @serhiy-storchaka @erlend-aasland @rhettinger @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.