GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-100485: Tighter accuracy testing of sumprod by rhettinger · Pull Request #101397 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented Jan 28, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Run the buildbots to make sure a condition number of 1e28 always passes. The theoretical limit is 1e25, but the paper indicates that we can get several orders of magnitude better in practice.

  • Issue: Consider adding sumproduct() or dotproduct() to the math module #100485

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
rhettinger added 6 commits January 28, 2023 07:50
@rhettinger
Fix hardwired constant
9a8e2ff
@rhettinger
Instead of median, test all examples better than the target condition…
de81730 
… number.
@rhettinger
Stronger test
078c1ec
@rhettinger
Replace relative error test with absolute test.
e3dbe9b
@rhettinger
Add comments and todo
df42d9f
@rhettinger
Relate the test parameters back to the paper
b7d72de
@rhettinger rhettinger added the skip news label Jan 28, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Jan 28, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jan 28, 2023
Consider adding sumproduct() or dotproduct() to the math module #100485
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Jan 28, 2023
@rhettinger rhettinger added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 28, 2023
@bedevere-bot

bedevere-bot commented Jan 28, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit b7d72de 🤖

If you want to schedule another build, you need to add the :hammer: test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jan 28, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @rhettinger for commit b7d72de 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed 🔨 test-with-buildbots Test PR w/ buildbots; report in status section 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Jan 28, 2023
@rhettinger rhettinger closed this Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rhettinger @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.