GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98831: Modernize the LOAD_GLOBAL family by gvanrossum · Pull Request #101502 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Feb 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Generate the interpreter #98831

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gvanrossum added 3 commits February 1, 2023 11:20
@gvanrossum
Modernize LOAD_GLOBAL
0f2129f
@gvanrossum
Modernize LOAD_GLOBAL_MODULE
995822a
@gvanrossum
Modernize LOAD_GLOBAL_BUILTIN
6868767
@gvanrossum gvanrossum added the skip news label Feb 1, 2023
@gvanrossum
gvanrossum requested a review from iritkatriel February 1, 2023 19:31
@bedevere-bot bedevere-bot added the awaiting core review label Feb 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 1, 2023
Generate the interpreter #98831
Closed
@gvanrossum gvanrossum added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 1, 2023
@bedevere-bot

bedevere-bot commented Feb 1, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gvanrossum for commit 6868767 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 1, 2023
@gvanrossum gvanrossum changed the title gh-98831: Load global family gh-98831: Modernize the LOAD_GLOBAL family Feb 1, 2023
@gvanrossum

gvanrossum commented Feb 1, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Hm, leaks in test_importlib (on one buildbot only so far, "aarch64 RHEL8 Refleaks PR"). Will investigate.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel

iritkatriel commented Feb 1, 2023

Copy link
Copy Markdown
Member

Hm, leaks in test_importlib (on one buildbot only so far, "aarch64 RHEL8 Refleaks PR"). Will investigate.

That buildbot in bad shape for a while. Look at the other runs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel approved these changes Feb 1, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 1, 2023
@gvanrossum

gvanrossum commented Feb 1, 2023

Copy link
Copy Markdown
Member Author

Yeah, the others seem fine. I'll just merge it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum
gvanrossum merged commit ae9b38f into python:main Feb 1, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 1, 2023
@gvanrossum
gvanrossum deleted the load-global-family branch February 1, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gvanrossum @bedevere-bot @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.