GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98831: Modernize CALL_FUNCTION_EX by gvanrossum · Pull Request #101627 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Feb 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is a straightforward use of a conditional input stack effect. The one tricky bit is that I had to cherry-pick a fix for CHECK_EVAL_BREAKER() from gh-101508. Whichever lands first, the other will have to drop that commit.

  • Issue: Generate the interpreter #98831

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum
gvanrossum requested a review from iritkatriel February 7, 2023 01:20
@bedevere-bot bedevere-bot added the awaiting core review label Feb 7, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 7, 2023
Generate the interpreter #98831
Closed
iritkatriel
iritkatriel reviewed Feb 7, 2023
View reviewed changes
Comment thread Python/generated_cases.c.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum gvanrossum added the skip news label Feb 7, 2023
@gvanrossum

gvanrossum commented Feb 7, 2023

Copy link
Copy Markdown
Member Author

On top of that the tests fail. Going back into draft mode.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum
gvanrossum marked this pull request as draft February 7, 2023 05:18
gvanrossum added 3 commits February 7, 2023 12:27
@gvanrossum
Special-case CHECK_EVAL_BREAKER()
c43d20b
@gvanrossum
Modernize CALL_FUNCTION_EX
f2bad0d
@gvanrossum
Fix crash due to refcount shenanigans
19307ba 
Also avoid compiler warning for unused variable 'null'
(used in assert only).
@gvanrossum
gvanrossum force-pushed the call-function-ex branch from 10dcbec to 19307ba Compare February 7, 2023 20:28
@gvanrossum gvanrossum added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 7, 2023
@bedevere-bot

bedevere-bot commented Feb 7, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gvanrossum for commit 19307ba 🤖

If you want to schedule another build, you need to add the :hammer: test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 7, 2023
@gvanrossum
gvanrossum marked this pull request as ready for review February 7, 2023 21:59
@gvanrossum

gvanrossum commented Feb 7, 2023

Copy link
Copy Markdown
Member Author

@iritkatriel Crash fixed, warning fixed, tests passed, refleak buildbots are running. Ready for your review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel approved these changes Feb 7, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 7, 2023
@gvanrossum

gvanrossum commented Feb 8, 2023

Copy link
Copy Markdown
Member Author

I'm taking the PPC64LE RHEL8 Refleaks PR buildbot failure as a flake.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum
gvanrossum merged commit a9f0144 into python:main Feb 8, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 8, 2023
@gvanrossum
gvanrossum deleted the call-function-ex branch February 8, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gvanrossum @bedevere-bot @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.