GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-96127: Fix `inspect.signature` call on mocks (#96335) by arhadthedev · Pull Request #101646 · python/cpython

Conversation

@arhadthedev

@arhadthedev arhadthedev commented Feb 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 9e7d726)

  • Issue: Calling inspect.signature with an AsyncMock instance raises an exception #96127

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn @arhadthedev
pythongh-96127: Fix inspect.signature call on mocks (python#96335)
01d94ca 
(cherry picked from commit 9e7d726)
@arhadthedev
arhadthedev requested a review from cjw296 as a code owner February 7, 2023 17:13
@bedevere-bot bedevere-bot added the awaiting review label Feb 7, 2023
This was referenced Feb 7, 2023
Calling inspect.signature with an AsyncMock instance raises an exception #96127
Closed
gh-96127: Fix inspect.signature call on mocks #96335
Merged
sobolevn
sobolevn approved these changes Feb 8, 2023
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
arhadthedev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Feb 8, 2023
@ambv
ambv merged commit efcab38 into python:3.11 Feb 8, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Feb 8, 2023
@arhadthedev
arhadthedev deleted the backport-9e7d726-3.11 branch February 8, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes
@cjw296 cjw296 Awaiting requested review from cjw296 cjw296 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@arhadthedev @sobolevn @ambv @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.