GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) by miss-islington · Pull Request #101709 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 8, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 23751ed)

Co-authored-by: Oleg Iarygin [email protected]

  • Issue: Undocumented risky behaviour in subprocess module #101283

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@arhadthedev @miss-islington
pythongh-101283: Improved fallback logic for subprocess with shell=Tr…
fccaea3 
…ue on Windows (pythonGH-101286)

(cherry picked from commit 23751ed)

Co-authored-by: Oleg Iarygin <[email protected]>
@miss-islington
miss-islington requested a review from gpshead as a code owner February 8, 2023 22:12
@bedevere-bot bedevere-bot added the awaiting review label Feb 8, 2023
This was referenced Feb 8, 2023
Undocumented risky behaviour in subprocess module #101283
Closed
gh-101283: Try to load the fallback cmd.exe by an absolute path #101286
Merged
@bedevere-bot bedevere-bot added the type-security A security issue label Feb 8, 2023
zooba
zooba reviewed Feb 8, 2023
View reviewed changes
Comment thread Doc/library/subprocess.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/subprocess.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/subprocess.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/subprocess.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/subprocess.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/subprocess.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@zooba
Apply suggestions from code review
c317691
zooba
zooba approved these changes Feb 8, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 8, 2023
@miss-islington

miss-islington commented Feb 8, 2023

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev
arhadthedev marked this pull request as draft February 9, 2023 03:39
@arhadthedev

arhadthedev commented Feb 9, 2023

Copy link
Copy Markdown
Member

Undrafting since the introduced bug will be fixed separately by backports of gh-101712. My apologizes for the confusion; I didn't sort out my incoming notifications timely.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev
arhadthedev marked this pull request as ready for review February 9, 2023 06:14
@ambv
ambv merged commit 04cc427 into python:3.9 Feb 9, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 9, 2023
@miss-islington
miss-islington deleted the backport-23751ed-3.9 branch February 9, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @arhadthedev @zooba @ambv @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.