GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) by zooba · Pull Request #101713 · python/cpython

Conversation

@zooba

@zooba zooba commented Feb 8, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Undocumented risky behaviour in subprocess module #101283

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@arhadthedev @zooba
pythongh-101283: Improved fallback logic for subprocess with shell=Tr…
e06a55e 
…ue on Windows (pythonGH-101286)
@zooba
zooba requested a review from gpshead as a code owner February 8, 2023 22:36
@bedevere-bot bedevere-bot added the awaiting core review label Feb 8, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 8, 2023
Undocumented risky behaviour in subprocess module #101283
Closed
@zooba zooba changed the title gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) [3.7] gh-101283: Improved fallback logic for subprocess with shell=True on Windows (GH-101286) Feb 8, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 8, 2023
gh-101283: Try to load the fallback cmd.exe by an absolute path #101286
Merged
@bedevere-bot bedevere-bot added the type-security A security issue label Feb 8, 2023
@zooba

zooba commented Feb 8, 2023

Copy link
Copy Markdown
Member Author

macOS crash is due to underlying OS update and not related to this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev
arhadthedev marked this pull request as draft February 9, 2023 03:38
@arhadthedev

arhadthedev commented Feb 9, 2023

Copy link
Copy Markdown
Member

Undrafting since the introduced bug will be fixed separately by backports of gh-101712. My apologizes for the confusion; I didn't sort out my incoming notifications timely.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev
arhadthedev marked this pull request as ready for review February 9, 2023 06:15
arhadthedev
arhadthedev reviewed Feb 9, 2023
View reviewed changes
Comment thread Doc/library/subprocess.rst
Comment on lines +453 to +454
.. versionchanged:: 3.6
*executable* parameter accepts a :term:`path-like object` on POSIX.

@arhadthedev arhadthedev Feb 9, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it added by mistake?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ambv ambv Feb 9, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was probably added to resolve the conflict but it belongs in the 3.7 docs as well. For some reason this doc bit wasn't ported back to 3.6 and 3.7 when Serhiy landed GH-5914.

I would leave it in.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
arhadthedev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
arhadthedev
arhadthedev reviewed Feb 9, 2023
View reviewed changes

@arhadthedev arhadthedev left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://www.python.org/downloads/ the next published 3.7 release will be 3.7.17.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/subprocess.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/subprocess.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/subprocess.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/subprocess.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/subprocess.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ambv @arhadthedev
Apply suggestions from code review
3196632 
Co-authored-by: Oleg Iarygin <[email protected]>
@ambv
ambv merged commit c7fdc9c into python:3.7 Feb 9, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Feb 9, 2023
@zooba
zooba deleted the gh-101283-3.7 branch February 9, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv left review comments
@arhadthedev arhadthedev arhadthedev left review comments
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@zooba @arhadthedev @ambv @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.