GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-101696: invalidate type version tag in `_PyStaticType_Dealloc` (GH-101697) by erlend-aasland · Pull Request #101722 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Feb 9, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit d9de079)

Co-authored-by: Kumar Aditya [email protected]

  • Issue: _PyStaticType_Dealloc does not invalidate type version tag #101696

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303 @erlend-aasland
[3.11] pythonGH-101696: invalidate type version tag in `_PyStaticType…
5f83520 
…_Dealloc` (pythonGH-101697).

(cherry picked from commit d9de079)

Co-authored-by: Kumar Aditya <[email protected]>
@erlend-aasland
erlend-aasland requested a review from markshannon as a code owner February 9, 2023 00:15
@bedevere-bot bedevere-bot added the awaiting core review label Feb 9, 2023
This was referenced Feb 9, 2023
_PyStaticType_Dealloc does not invalidate type version tag #101696
Closed
GH-101696: invalidate type version tag in _PyStaticType_Dealloc #101697
Merged
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Feb 9, 2023
@erlend-aasland
erlend-aasland requested a review from kumaraditya303 February 9, 2023 00:15
@ambv
ambv marked this pull request as draft February 9, 2023 10:11
@ambv

ambv commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

Converting to draft per unresolved discussion item in the original PR: #101697 (comment)
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
kumaraditya303 marked this pull request as ready for review February 10, 2023 17:14
@kumaraditya303

kumaraditya303 commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

See discussion on issue, we'll proceed with this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes Feb 10, 2023
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 10, 2023
@kumaraditya303
kumaraditya303 merged commit c5c1238 into python:3.11 Feb 11, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 11, 2023
@erlend-aasland
erlend-aasland deleted the backport-d9de079-3.11 branch February 11, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@erlend-aasland @ambv @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.