GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101517: Attach line number to the RERAISE at the end of a try-except* by iritkatriel · Pull Request #101768 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Feb 10, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Bug in linecache when raising exceptiongroup that contains ZeroDivisionError + other exception. #101517

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iritkatriel added 2 commits February 9, 2023 22:14
@iritkatriel
add test
4ffdc37
@iritkatriel
give RERAISE a location
35b3c76
@iritkatriel
iritkatriel requested a review from markshannon as a code owner February 10, 2023 00:22
@bedevere-bot bedevere-bot added the awaiting core review label Feb 10, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 10, 2023
Bug in linecache when raising exceptiongroup that contains ZeroDivisionError + other exception. #101517
Closed
@iritkatriel iritkatriel closed this Feb 13, 2023
@iritkatriel iritkatriel reopened this Feb 13, 2023
hugovk
hugovk reviewed Feb 13, 2023
View reviewed changes
Comment thread Lib/test/test_pdb.py Outdated
Comment on lines +1412 to +1431
"""See GH-101517

breakpoint in except* clause

>>> def test_function():
... try:
... raise ExceptionGroup("eg", [KeyError(), ValueError()])
... except* KeyError:
... breakpoint()
...
>>> with PdbTestInput([ # doctest: +NORMALIZE_WHITESPACE
... 'continue'
... ]):
... try:
... test_function()
... except Exception as e:
... print(repr(e))
ExceptionGroup('eg', [ValueError()])
>>>
"""

@hugovk hugovk Feb 13, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make patchcheck on the CI doesn't like these 5-space indents.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@iritkatriel
fix whitespace
f6273a5
@iritkatriel

iritkatriel commented Apr 13, 2023

Copy link
Copy Markdown
Member Author

This is wrong, I'll do something else.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @hugovk @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.