GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-85984: Major revision of the pty library. by 8vasu · Pull Request #101833 · python/cpython

Conversation

@8vasu

@8vasu 8vasu commented Feb 11, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This follows #92365. This is one in a series of PRs aimed at cleaning-up, fixing bugs in, introducing new features in, and updating the code in "Lib/pty.py".

This is expected to fail before the following prerequisites are merged: #101832 and #102413.

Signed-off-by: Soumendra Ganguly [email protected]

  • Issue: Lib/pty.py major revision #85984

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@8vasu
Major revision of the pty library.
dc6a90d 
Signed-off-by: Soumendra Ganguly <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label Feb 11, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 11, 2023
Lib/pty.py major revision #85984
Open
@blurb-it
📜🤖 Added by blurb_it.
edd1a12
This was referenced Feb 11, 2023
gh-85984: New additions and improvements to the tty library. #101832
Merged
gh-85984: Utilize new "winsize" functions from termios in pty tests. #101831
Merged
@8vasu

8vasu commented Feb 11, 2023

Copy link
Copy Markdown
Contributor Author

@gpshead This is the main set of changes in this series, but it will not work without
the prerequisites mentioned in the main comment. I am only creating this for your
reference (this explains a lot of the changes/additions in the prerequisite PRs).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
8vasu
8vasu commented Feb 11, 2023
View reviewed changes
Comment thread Lib/pty.py
fds = [master_fd, STDIN_FILENO]
while fds:
rfds, _wfds, _xfds = select(fds, [], [])
while True:

@8vasu 8vasu Feb 11, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think that fds is ever empty in this loop. Therefore, I replaced while fds: with the original while True:. Please correct me if I am wrong.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@8vasu
8vasu marked this pull request as draft February 12, 2023 23:10
@8vasu 8vasu mentioned this pull request Mar 4, 2023
gh-85984: Add POSIX pseudo-terminal functions. #102413
Merged
@8vasu 8vasu mentioned this pull request Feb 4, 2024
gh-85984: Add _POSIX_VDISABLE from unistd.h to termios module. #114985
Merged
@github-actions

github-actions Bot commented Apr 12, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 12, 2026
@ambv

ambv commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

This PR is blocked on its author, has not been touched by a human in more than 3 years, and no longer merges cleanly. Closing to cull the number of open pull requests. Do not reopen this pull request without getting a go-ahead from a triager or core developer on gh-85984.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv closed this Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@8vasu @ambv @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.