GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101928: fix crash in compiler on multi-line lambda in function call by penguin-wwy · Pull Request #101933 · python/cpython

Conversation

@penguin-wwy

@penguin-wwy penguin-wwy commented Feb 15, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Multi-line arguments in a function call crashes CPython #101928

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@penguin-wwy
Fix crash caused by RETURN_CONST
60e719a
@penguin-wwy
penguin-wwy requested review from iritkatriel and markshannon as code owners February 15, 2023 12:35
@bedevere-bot bedevere-bot added the awaiting review label Feb 15, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 15, 2023
Multi-line arguments in a function call crashes CPython #101928
Closed
@iritkatriel

iritkatriel commented Feb 15, 2023

Copy link
Copy Markdown
Member

Please add a unit test with the code from the issue, to prevent regressions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@penguin-wwy
Add unittest
a082285
@penguin-wwy

penguin-wwy commented Feb 16, 2023

Copy link
Copy Markdown
Contributor Author

Thank you for the reminder :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel changed the title gh-101928: Replace RETURN_CONST in the correct place gh-101928: fix crash in compiler on multi-line lambda in function call Feb 16, 2023
@iritkatriel iritkatriel added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump labels Feb 16, 2023
@iritkatriel
Merge branch 'main' into fix_issue101928
38bf291
iritkatriel
iritkatriel approved these changes Feb 16, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 16, 2023
@iritkatriel

iritkatriel commented Feb 16, 2023

Copy link
Copy Markdown
Member

Skipping news because this bug was only introduced last week.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel added skip news release-blocker labels Feb 16, 2023
@iritkatriel
iritkatriel merged commit df7ccf6 into python:main Feb 16, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 16, 2023
@iritkatriel iritkatriel mentioned this pull request Mar 1, 2023
s390x RHEL7 got crash on the refleak test #102351
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker skip news type-bug An unexpected behavior, bug, or error type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@penguin-wwy @iritkatriel @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.