GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101766: Fix refleak for _BlockingOnManager resources at test-suite level by corona10 · Pull Request #101987 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Feb 17, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Refleak in test_importlib on aarch64 RHEL8 #101766

Reverting the change due to #101942 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
corona10 added 2 commits February 17, 2023 11:51
@corona10
Revert "pythongh-101766: Fix refleak for _BlockingOnManager resources (…
707db41 
…pythongh-101942)"

This reverts commit 775f881.
@corona10
pythongh-101766: Fix refleak for _BlockingOnManager resources
6d667d4
@corona10
corona10 requested a review from gvanrossum February 17, 2023 12:29
@bedevere-bot bedevere-bot added the awaiting core review label Feb 17, 2023
@corona10
corona10 marked this pull request as ready for review February 17, 2023 12:29
@bedevere-bot bedevere-bot mentioned this pull request Feb 17, 2023
Refleak in test_importlib on aarch64 RHEL8 #101766
Closed
@corona10 corona10 added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 17, 2023
@bedevere-bot

bedevere-bot commented Feb 17, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @corona10 for commit 6d667d4 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 17, 2023
@corona10
corona10 requested a review from sobolevn February 17, 2023 12:29
@corona10 corona10 added skip issue skip news and removed skip issue labels Feb 17, 2023
@corona10

corona10 commented Feb 17, 2023

Copy link
Copy Markdown
Member Author

@exarkun Would you like to take a look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Feb 17, 2023

Copy link
Copy Markdown
Member Author

FYI,
I verified this PR by running 50 times refleak test suite for the test_importlib
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Feb 17, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Oops it doesn't solve the issue
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 closed this Feb 17, 2023
@exarkun

exarkun commented Feb 17, 2023

Copy link
Copy Markdown
Contributor

Oops it doesn't solve the issue

I would make one PR that just reverts the original change followed by another PR that fixes the object leak. That way the eventual fix is not mixed together with remnants of the earlier incomplete fix. Also, it lets the regression in importlib get fixed immediately while we take what time we need to fix the object leak.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@sobolevn sobolevn Awaiting requested review from sobolevn

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@corona10 @bedevere-bot @exarkun
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.