GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101981: Update macOS workflow by corona10 · Pull Request #101991 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Feb 17, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: CI: intermittent macOS failures for make checksharedmods #101981

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

OTheDev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added the awaiting core review label Feb 17, 2023
@corona10
corona10 force-pushed the mac_os_fix branch 7 times, most recently from 7677da1 to c170cca Compare February 17, 2023 15:53
@corona10 corona10 changed the title .github: Update macOS openSSL configuration gh-101981: Update macOS workflow Feb 17, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 17, 2023
CI: intermittent macOS failures for make checksharedmods #101981
Closed
@corona10
corona10 marked this pull request as ready for review February 17, 2023 15:54
@corona10
corona10 requested a review from ezio-melotti as a code owner February 17, 2023 15:54
@corona10 corona10 added skip news needs backport to 3.10 needs backport to 3.11 only security fixes labels Feb 17, 2023
@corona10
corona10 requested a review from ned-deily February 17, 2023 15:54
ned-deily
ned-deily requested changes Feb 17, 2023
View reviewed changes
Comment thread .github/workflows/build.yml Outdated
brew install pkg-config [email protected] xz gdbm tcl-tk
echo "CFLAGS=-I$(brew --prefix gdbm)/include -I$(brew --prefix xz)/include" >> $GITHUB_ENV
echo "LDFLAGS=-L$(brew --prefix gdbm)/lib -I$(brew --prefix xz)/lib" >> $GITHUB_ENV
echo "PKG_CONFIG_PATH=$(brew --prefix tcl-tk)/lib/pkgconfig" >> $GITHUB_ENV

@ned-deily ned-deily Feb 17, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not follow the devguide recipe and use one shell line? Those variables should only be needed for the configure command

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

corona10 and erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

@corona10 corona10 Feb 17, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ned-deily

  • multi line string needs to declare sperate variable for this: https://trstringer.com/github-actions-multiline-strings/
    So we use single line command most of cases.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@ned-deily ned-deily Feb 17, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • multi line string needs to declare sperate variable for this: https://trstringer.com/github-actions-multiline-strings/

But the devguide recipe does not consist of multiple commands on multiple lines as in that link, i.e. it's not "in the form of an output from one step, and an input to another step". It's a single shell command that has been split across lines in the devguide for readability and it doesn't need to be. (The POSIX command language standard calls it a "simple command": "A simple command is a sequence of optional variable assignments and redirections, in any sequence, optionally followed by words and redirections, terminated by a control operator." There is no piping involved here.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting core review labels Feb 17, 2023
@bedevere-bot

bedevere-bot commented Feb 17, 2023

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@corona10

corona10 commented Feb 18, 2023

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

I am thinking about how to resolve test_freeze_simple_script

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Feb 18, 2023
@corona10
corona10 requested a review from ned-deily February 18, 2023 02:15
@corona10 corona10 changed the title gh-101981: Update macOS workflow [WIP] gh-101981: Update macOS workflow Feb 18, 2023
corona10 added 3 commits February 18, 2023 14:55
@corona10
pythongh-101981: Update macOS workflow
5d66946
@corona10
Address code review
9a72bf0
@corona10
Address code review
28c8fa3
@corona10
corona10 force-pushed the mac_os_fix branch 2 times, most recently from 8c3019e to 28c8fa3 Compare February 18, 2023 06:30
@corona10
corona10 force-pushed the mac_os_fix branch 2 times, most recently from ce7ba2e to 28c8fa3 Compare February 18, 2023 07:42
@corona10
temporal fix
ca979d3
@corona10 corona10 closed this Feb 18, 2023
@corona10 corona10 reopened this Feb 18, 2023
@corona10 corona10 changed the title [WIP] gh-101981: Update macOS workflow gh-101981: Update macOS workflow Feb 18, 2023
@corona10

corona10 commented Feb 18, 2023

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Feb 18, 2023

Copy link
Copy Markdown

Thanks for making the requested changes!

@ned-deily: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@corona10 corona10 mentioned this pull request Feb 20, 2023
gh-101981: Build macOS as recommended by the devguide #102070
Merged
@corona10 corona10 closed this Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@ned-deily ned-deily Awaiting requested review from ned-deily

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting change review needs backport to 3.11 only security fixes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@corona10 @bedevere-bot @ned-deily
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.