GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — gh-101981: Update macOS workflow by corona10 · Pull Request #101991 · python/cpython Conversation
|
| brew install pkg-config [email protected] xz gdbm tcl-tk | ||
| echo "CFLAGS=-I$(brew --prefix gdbm)/include -I$(brew --prefix xz)/include" >> $GITHUB_ENV | ||
| echo "LDFLAGS=-L$(brew --prefix gdbm)/lib -I$(brew --prefix xz)/lib" >> $GITHUB_ENV | ||
| echo "PKG_CONFIG_PATH=$(brew --prefix tcl-tk)/lib/pkgconfig" >> $GITHUB_ENV |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Why not follow the devguide recipe and use one shell line? Those variables should only be needed for the configure command
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
- multi line string needs to declare sperate variable for this: https://trstringer.com/github-actions-multiline-strings/
But the devguide recipe does not consist of multiple commands on multiple lines as in that link, i.e. it's not "in the form of an output from one step, and an input to another step". It's a single shell command that has been split across lines in the devguide for readability and it doesn't need to be. (The POSIX command language standard calls it a "simple command": "A simple command is a sequence of optional variable assignments and redirections, in any sequence, optionally followed by words and redirections, terminated by a control operator." There is no piping involved here.)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
When you're done making the requested changes, leave the comment: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I have made the requested changes; please review again I am thinking about how to resolve test_freeze_simple_script |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
8c3019e to
28c8fa3
Compare
ce7ba2e to
28c8fa3
Compare
|
I have made the requested changes; please review again |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for making the requested changes! @ned-deily: please review the changes made to this pull request. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.