GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-101981: Build macOS as recommended by the devguide (GH-102070) by miss-islington · Pull Request #102073 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 20, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 2713631)

Co-authored-by: Erlend E. Aasland [email protected]
Automerge-Triggered-By: GH:erlend-aasland

  • Issue: CI: intermittent macOS failures for make checksharedmods #101981

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland @miss-islington
pythongh-101981: Build macOS as recommended by the devguide (pythonGH…
1054aa5 
…-102070)

(cherry picked from commit 2713631)

Co-authored-by: Erlend E. Aasland <[email protected]>
Automerge-Triggered-By: GH:erlend-aasland
@miss-islington
miss-islington requested a review from ezio-melotti as a code owner February 20, 2023 13:07
@bedevere-bot bedevere-bot added the awaiting review label Feb 20, 2023
This was referenced Feb 20, 2023
CI: intermittent macOS failures for make checksharedmods #101981
Closed
gh-101981: Build macOS as recommended by the devguide #102070
Merged
@bedevere-bot bedevere-bot added the skip news label Feb 20, 2023
erlend-aasland
erlend-aasland approved these changes Feb 20, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 20, 2023
@erlend-aasland

erlend-aasland commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

cc. @corona10, @hugovk: any idea regarding the OpenSSL 3.1.0-beta1 failure?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Feb 20, 2023

Copy link
Copy Markdown
Member 
install apps/openssl -> /home/runner/work/cpython/cpython/multissl/openssl/3.1.0-beta1/bin/openssl
install tools/c_rehash -> /home/runner/work/cpython/cpython/multissl/openssl/3.1.0-beta1/bin/c_rehash
/home/runner/work/cpython/cpython/multissl/openssl/3.1.0-beta1/bin/openssl: error while loading shared libraries: libssl.so.3: cannot open shared object file: No such file or directory
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Feb 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Re-run the job?, I would like to check if this is a temporal issue or not.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Feb 20, 2023

Copy link
Copy Markdown
Member

Ah okay..


install libssl.so.3 -> /home/runner/work/cpython/cpython/multissl/openssl/3.1.0-beta1/lib64/libssl.so.3
/home/runner/work/cpython/cpython/multissl/openssl/3.1.0-beta1/bin/openssl: error while loading shared libraries: libssl.so.3: cannot open shared object file: No such file or directory
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Feb 20, 2023

Copy link
Copy Markdown
Member

It's a failing Ubuntu job, so unrelated to this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes Feb 20, 2023
View reviewed changes
@corona10

corona10 commented Feb 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It's a failing Ubuntu job, so unrelated to this PR.

+1, Should be solved by a separate issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10
corona10 approved these changes Feb 20, 2023
View reviewed changes
@erlend-aasland

erlend-aasland commented Feb 20, 2023

Copy link
Copy Markdown
Contributor

cc. @pablogsal as RM for Python 3.10; see comments about failing CI. Are you fine with me landing this?
pablogsal reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Feb 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Thanks for checking with me!

This looks good to me but I am not sure what comment are your referring to about failing CI. It seems that the issue in the CI was transient/unrelated, no?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Feb 20, 2023

Copy link
Copy Markdown
Member

Yes, unrelated, and also failing on a clean 3.10 run:

https://github.com/hugovk/cpython/actions/runs/4224278452/jobs/7335046068
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit 63877f6 into python:3.10 Feb 20, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 20, 2023
@miss-islington
miss-islington deleted the backport-2713631-3.10 branch February 20, 2023 14:52
@corona10

corona10 commented Feb 20, 2023

Copy link
Copy Markdown
Member

See how to fix it: #102079
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@corona10 corona10 corona10 approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@miss-islington @erlend-aasland @corona10 @hugovk @pablogsal @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.