GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-88233: zipfile: handle extras after a zip64 extra (GH-96161) by miss-islington · Pull Request #102087 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Previously, any data after the zip64 extra would be removed.

With many new tests.

Fixes GH-88233
(cherry picked from commit 59e86ca)

Co-authored-by: Tim Hatch [email protected]
Automerge-Triggered-By: GH:jaraco

Automerge-Triggered-By: GH:jaraco

Automerge-Triggered-By: GH:AlexWaygood

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@thatch @miss-islington
pythongh-88233: zipfile: handle extras after a zip64 extra (pythonGH-…
0959162 
…96161)

Previously, any data _after_ the zip64 extra would be removed.

With many new tests.

Fixes pythonGH-88233
(cherry picked from commit 59e86ca)

Co-authored-by: Tim Hatch <[email protected]>
Automerge-Triggered-By: GH:jaraco
@bedevere-bot bedevere-bot added the awaiting review label Feb 20, 2023
This was referenced Feb 20, 2023
Zipfile lib overwrites the extra field during closing when the archive size is more then ZIP64_LIMIT #88233
Closed
gh-88233: zipfile: handle extras after a zip64 extra #96161
Merged
jaraco
jaraco approved these changes Feb 20, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 20, 2023
@jaraco jaraco added 🤖 automerge and removed awaiting merge labels Feb 20, 2023
@hugovk

hugovk commented Mar 23, 2023

Copy link
Copy Markdown
Member

@jaraco This didn't automerge for some reason, want to manually hit the merge button?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added awaiting merge 🤖 automerge and removed 🤖 automerge labels Mar 23, 2023
@ambv
ambv merged commit d445147 into python:3.10 Mar 28, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 28, 2023
@miss-islington
miss-islington deleted the backport-59e86ca-3.10 branch March 28, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco jaraco approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@miss-islington @hugovk @jaraco @ambv @bedevere-bot @AlexWaygood @thatch
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.