GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-101936: Update the default value of fp from io.StringIO to io.BytesIO (gh-102100) by miss-islington · Pull Request #102118 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 21, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 0d4c7fc)

Co-authored-by: Vo Hoang Long [email protected]
Co-authored-by: Long Vo [email protected]

  • Issue: HTTPError fp.read returns string instead of bytes  #101936

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@longvhdeveloper @miss-islington
pythongh-101936: Update the default value of fp from io.StringIO to i…
496a500 
…o.BytesIO (pythongh-102100)

(cherry picked from commit 0d4c7fc)

Co-authored-by: Vo Hoang Long <[email protected]>
Co-authored-by: Long Vo <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label Feb 21, 2023
This was referenced Feb 21, 2023
HTTPError fp.read returns string instead of bytes #101936
Closed
gh-101936: Update the default value of fp from io.StringIO to io.BytesIO #102100
Merged
@ghost

ghost commented Feb 21, 2023

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

  • [email protected]

Click the button to sign:
CLA not signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 merged commit 0f28af5 into python:3.10 Feb 22, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Feb 22, 2023
@miss-islington
miss-islington deleted the backport-0d4c7fc-3.10 branch February 22, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @corona10 @bedevere-bot @longvhdeveloper
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.