GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-97786: Fix compiler warnings in pytime.c (GH-101826) by mdickinson · Pull Request #102150 · python/cpython

Conversation

@mdickinson

@mdickinson mdickinson commented Feb 22, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes compiler warnings in pytime.c..
(cherry picked from commit b1b375e)

  • Issue: Compiler warning for _Py_InIntegralTypeRange #97786

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mdickinson
[3.10] pythongh-97786: Fix compiler warnings in pytime.c (pythonGH-10…
3d56ece 
…1826)

Fixes compiler warnings in pytime.c..
(cherry picked from commit b1b375e)

Co-authored-by: Mark Dickinson <[email protected]>
@mdickinson
mdickinson requested review from abalkin and pganssle as code owners February 22, 2023 20:05
@bedevere-bot bedevere-bot added the awaiting core review label Feb 22, 2023
This was referenced Feb 22, 2023
Compiler warning for _Py_InIntegralTypeRange #97786
Closed
gh-97786: Fix compiler warnings in pytime.c #101826
Merged
@mdickinson mdickinson added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2023
@bedevere-bot

bedevere-bot commented Feb 22, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @mdickinson for commit 3d56ece 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 22, 2023
@gpshead
Merge branch '3.10' into backport-b1b375e-3.10
a54b679
@gpshead

gpshead commented Feb 23, 2023

Copy link
Copy Markdown
Member

!buildbot wasm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Feb 23, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @gpshead for commit a54b679 🤖

The command will test the builders whose names match following regular expression: wasm

The builders matched are:

  • wasm32-emscripten node (pthreads) PR
  • wasm32-emscripten browser (dynamic linking, no tests) PR
  • wasm32-wasi PR
  • wasm32-emscripten node (dynamic linking) PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
abalkin
abalkin approved these changes Feb 23, 2023
View reviewed changes

@abalkin abalkin left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this has already been merged in main (gh-97786), there isn't real need for a review.

In any case, LGTM. I just added a suggestion that should not hold this from being merged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Python/pytime.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 23, 2023
@mdickinson
Add comment about the casts
7e97e91
@mdickinson
mdickinson merged commit 5b610b5 into python:3.10 Feb 26, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 26, 2023
@mdickinson
mdickinson deleted the backport-b1b375e-3.10 branch February 26, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abalkin abalkin abalkin approved these changes
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mdickinson @bedevere-bot @gpshead @abalkin
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.