GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102204: Fix endianness issue in AIX by ayappanec · Pull Request #102206 · python/cpython

Conversation

@ayappanec

@ayappanec ayappanec commented Feb 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR is to fix the problem mentioned in the issue #102204

  • Issue: AIX build with XLC compiler fails with main branch #102204

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ayappanec added 2 commits February 24, 2023 03:33
@ayappanec
pythongh-102204: Fix endianness issue in AIX
d5b132a
@ayappanec
Add NEWS entry
d73e44f
@bedevere-bot bedevere-bot added the awaiting review label Feb 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 24, 2023
AIX build with XLC compiler fails with main branch #102204
Closed
@arhadthedev arhadthedev added the build The build process and cross-build label Feb 24, 2023
ayappanec added 2 commits February 27, 2023 15:49
@ayappanec
Merge branch 'main' into pythongh-102204
43871c1
@ayappanec
Merge branch 'main' into pythongh-102204
388d77b
@ayappanec

ayappanec commented Mar 10, 2023

Copy link
Copy Markdown
Contributor Author

Can someone review this ? It's a small change which fixes the _hacl module build in AIX.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev

arhadthedev commented Apr 1, 2023

Copy link
Copy Markdown
Member

@gpshead (as an active core dev who participated in gh-99109 that introduced the file this PR changes).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead

gpshead commented Apr 2, 2023

Copy link
Copy Markdown
Member

This code comes from the upstream HACL* project, can you also file an issue or PR with them to get AIX-relevant code into https://github.com/hacl-star/hacl-star/blob/main/dist/karamel/include/krml/lowstar_endianness.h?
ayappanec reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead self-assigned this Apr 2, 2023
This was referenced Apr 3, 2023
Fix endianness issue in AIX hacl-star/hacl-star#797
Closed
Fix endianness issue in AIX FStarLang/karamel#340
Merged
@gpshead

gpshead commented May 16, 2023

Copy link
Copy Markdown
Member

it looks like this was fixed upstream and we recently pulled in an updated hacl* when the sha3 code was merged. can you check main today and see if there is still any work to be done?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead closed this May 20, 2023
@ayappanec

ayappanec commented May 23, 2023

Copy link
Copy Markdown
Contributor Author

it looks like this was fixed upstream and we recently pulled in an updated hacl* when the sha3 code was merged. can you check main today and see if there is still any work to be done?

It works now. Thanks for the support.
gpshead reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

awaiting review build The build process and cross-build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ayappanec @arhadthedev @gpshead @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.