GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102202: Update bundled setuptools to 67.4.0 by hugovk · Pull Request #102208 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Feb 24, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There are plans to remove setuptools from 3.12 (issue #95299 / PR #101039), but in the meantime we could include this in main/3.12 and backport it to deal with CVE-2022-40897 in setuptools. Or else skip 3.12 and apply to 3.11 with backports.

Python 3.7-3.9 are in security-fix only, so ping release managers @ambv and @ned-deily to decide if it's worth backporting there.

Also cc @pradyunsg and @pfmoore as packaging experts.

  • Issue: Update bundled setuptools provided by ensurepip in current 3.8.x through 3.11.x to include fix for CVE-2022-40897? #102202

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hugovk
pythongh-102202: Update bundled setuptools to 67.4.0
27b76e6
@hugovk hugovk added needs backport to 3.10 needs backport to 3.11 only security fixes labels Feb 24, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Feb 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 24, 2023
Update bundled setuptools provided by ensurepip in current 3.8.x through 3.11.x to include fix for CVE-2022-40897? #102202
Closed
@arhadthedev

arhadthedev commented Feb 24, 2023

Copy link
Copy Markdown
Member

I believe 3.12 definitely should include this version bump. It's unknown whether gh-101039 will land without breaking the world in 3.12 beta thus being retracted.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pradyunsg

pradyunsg commented Feb 24, 2023

Copy link
Copy Markdown
Member

It's unknown whether gh-101039 will land without breaking the world in 3.12 beta thus being retracted.

Well, it won't break the world really; since pip will pull in the relevant dependencies "under the hood" and do the right things. The only reason I've not merged that in is that I'm still not 100% confident what to do reg the extension test in there.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CAM-Gerlach

CAM-Gerlach commented Feb 25, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

As this is a security fix, I would think that could justify backporting assuming the issue is sufficiently serious relative to the potential disruption, though that is ultimately up to the RMs of course. Maybe just tag with the appropriate needs-backport labels to ensure they see it (since it will need to be an admin/RM to merge to those branches anyway)?

pradyunsg reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk
Merge branch 'main' into 102202-bump-setuptools
eb21235
@ned-deily

ned-deily commented Feb 26, 2023

Copy link
Copy Markdown
Member

I don't want to backport this to 3.7. The last time we tried to update setuptools in older releases about a year ago, we ended up having to revert the backports because of various issues; see #91142. While some of those issues may have been fixed in newer versions of setuptools, I have verified that there is at least one test suite failure on 3.7 with the latest setuptools. And, for releases in the late stages of their security-fix-only life cycles, it seems to me that the usage of ensurepip should be minimal anyway. At this point, almost no users should be starting a first-time installation of 3.7, say, from scratch. They will almost certainly either be using a 3.7.x release from a third-party distributor who will have their own setuptools package or they will be updating an existing installation and will be managing additional packages, like setuptools, on their own.

pradyunsg, hugovk, and AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pradyunsg

pradyunsg commented Feb 26, 2023

Copy link
Copy Markdown
Member

FWIW, I don't understand how/why the CVE is "high" severity since most sane configurations will not use setuptools' logic for parsing the index page anyway. 😅

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk removed the needs backport to 3.10 label Apr 7, 2023
@hugovk

hugovk commented Apr 27, 2023

Copy link
Copy Markdown
Member Author

Setuptools was removed from 3.12 in #101039 so if it's decided this needs backporting to any of 3.11-3.8, that'll need a new PR.

A 3.7 backport was ruled out as too low benefit/high risk by the release manager: #102202 (comment).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk hugovk closed this Apr 27, 2023
@hugovk
hugovk deleted the 102202-bump-setuptools branch April 27, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review needs backport to 3.11 only security fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@hugovk @arhadthedev @pradyunsg @CAM-Gerlach @ned-deily @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.