GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-85417: Clarify behaviour on branch cuts in cmath module (GH-102046) by miss-islington · Pull Request #102276 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 26, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR updates the cmath module documentation to reflect the reality that Python is almost always (and as far as I can tell, that "almost" can be omitted) running on a machine whose C double supports signed zeros.

  • Removes misleading references to functions being continuous from above / below / the left / the right at branch cuts
  • Expands the note on branch cuts at the top of the module documentation to explain the double-sided sign-of-zero-based behaviour
    (cherry picked from commit b513c46)

Co-authored-by: Mark Dickinson [email protected]

  • Issue: cmath module documentation is misleading on branch cuts #85417

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@mdickinson @miss-islington
pythongh-85417: Clarify behaviour on branch cuts in cmath module (pyt…
c95dd17
…honGH-102046)

This PR updates the cmath module documentation to reflect the reality that Python is almost always (and as far as I can tell, that "almost" can be omitted) running on a machine whose C double supports signed zeros.

* Removes misleading references to functions being continuous from above / below / the left / the right at branch cuts
* Expands the note on branch cuts at the top of the module documentation to explain the double-sided sign-of-zero-based behaviour
(cherry picked from commit b513c46)

Co-authored-by: Mark Dickinson <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label Feb 26, 2023
This was referenced Feb 26, 2023
cmath module documentation is misleading on branch cuts #85417
Closed
gh-85417: Clarify behaviour on branch cuts in cmath module #102046
Merged
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Feb 26, 2023
@mdickinson
mdickinson merged commit 626f471 into python:3.11 Feb 26, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Feb 26, 2023
@miss-islington
miss-islington deleted the backport-b513c46-3.11 branch February 26, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @mdickinson @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.