GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102344: implement winreg QueryValue / SetValue using QueryValueEx / SetValueEx by maxbachmann · Pull Request #102345 · python/cpython

Conversation

@maxbachmann

@maxbachmann maxbachmann commented Feb 28, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Some review already took place in #102256:

  • implementation for QueryValueEx / SetValueEx should possibly be cleaned up as well by using a similar structure
  • The two could possibly share some part of the implementation
  • Issue: implement winreg QueryValue / SetValue using QueryValueEx / SetValueEx #102344

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@maxbachmann
reimplement QueryValue / SetValue
0d928df
@maxbachmann
maxbachmann requested a review from a team as a code owner February 28, 2023 22:10
@bedevere-bot bedevere-bot added the awaiting review label Feb 28, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 28, 2023
implement winreg QueryValue / SetValue using QueryValueEx / SetValueEx #102344
Closed
maxbachmann added 4 commits February 28, 2023 23:11
@maxbachmann
refactor QueryValueEx
e0b256d
@maxbachmann
cleanup
799f380
@maxbachmann
fix type
67ef9f3
@maxbachmann
remove unused variables
fbc1a0e
@maxbachmann maxbachmann mentioned this pull request Feb 28, 2023
gh-102255: Improve build support on xbox #102256
Merged
@eryksun eryksun added the OS-windows label Feb 28, 2023
maxbachmann and others added 2 commits March 1, 2023 01:06
@maxbachmann
fix duplicated variable name
de0549b
@maxbachmann
add news
deca441
eryksun
eryksun reviewed Mar 1, 2023
View reviewed changes
Comment thread PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
maxbachmann and others added 2 commits March 1, 2023 02:36
@maxbachmann @eryksun
Update PC/winreg.c
2c95f23 
Co-authored-by: Eryk Sun <[email protected]>
@maxbachmann
revert part
8a4543b
zooba
zooba reviewed Mar 1, 2023
View reviewed changes
Comment thread PC/winreg.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Core and Builtins/2023-03-01-01-36-39.gh-issue-102344.Dgfux4.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@maxbachmann
move news
8397a2f
@zooba
zooba merged commit c1748ed into python:main Mar 1, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Mar 1, 2023
@eryksun

eryksun commented Mar 1, 2023

Copy link
Copy Markdown
Contributor

Why did you revert the update of winreg_QueryValueEx_impl()? Did it cause tests to fail?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@maxbachmann

maxbachmann commented Mar 1, 2023

Copy link
Copy Markdown
Contributor Author

yes I reverted it, since it caused test timeouts. I was not directly sure what I did wrong, so I reverted it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eryksun eryksun eryksun left review comments
@zooba zooba zooba left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-windows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@maxbachmann @eryksun @zooba @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.