GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101101: Fix test_code_extra to reset value for refleak test by corona10 · Pull Request #102350 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Mar 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Unstable C API tier (PEP 689) #101101

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@corona10
pythongh-101101: Fix test_code_extra to reset value for refleak test
dcb4d94
@corona10
corona10 requested a review from encukou March 1, 2023 06:58
@bedevere-bot bedevere-bot added the awaiting core review label Mar 1, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 1, 2023
Unstable C API tier (PEP 689) #101101
Closed
5 of 13 tasks
@corona10 corona10 added skip news 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section labels Mar 1, 2023
@bedevere-bot

bedevere-bot commented Mar 1, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @corona10 for commit dcb4d94 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Mar 1, 2023
@corona10

corona10 commented Mar 1, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

With out this patch:


➜  cpython git:(main) ✗ ./python.exe -m test test_capi -R 3:3
Raised RLIMIT_NOFILE: 256 -> 1024
0:00:00 load avg: 3.41 Run tests sequentially
0:00:00 load avg: 3.41 [1/1] test_capi
beginning 6 repetitions
123456
.Assertion failed: (extra == NULL), function test_code_extra, file code.c, line 82.
Fatal Python error: Aborted

Current thread 0x0000000104ba8580 (most recent call first):
  File "/Users/user/oss/cpython/Lib/unittest/case.py", line 579 in _callTestMethod
  File "/Users/user/oss/cpython/Lib/unittest/case.py", line 623 in run
  File "/Users/user/oss/cpython/Lib/unittest/case.py", line 678 in __call__
  File "/Users/user/oss/cpython/Lib/unittest/suite.py", line 122 in run
  File "/Users/user/oss/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/Users/user/oss/cpython/Lib/unittest/suite.py", line 122 in run
  File "/Users/user/oss/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/Users/user/oss/cpython/Lib/unittest/suite.py", line 122 in run
  File "/Users/user/oss/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/Users/user/oss/cpython/Lib/unittest/suite.py", line 122 in run
  File "/Users/user/oss/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/Users/user/oss/cpython/Lib/unittest/suite.py", line 122 in run
  File "/Users/user/oss/cpython/Lib/unittest/suite.py", line 84 in __call__
  File "/Users/user/oss/cpython/Lib/test/support/testresult.py", line 140 in run
  File "/Users/user/oss/cpython/Lib/test/support/__init__.py", line 1104 in _run_suite
  File "/Users/user/oss/cpython/Lib/test/support/__init__.py", line 1230 in run_unittest
  File "/Users/user/oss/cpython/Lib/test/libregrtest/runtest.py", line 281 in _test_module
  File "/Users/user/oss/cpython/Lib/test/libregrtest/refleak.py", line 89 in dash_R
  File "/Users/user/oss/cpython/Lib/test/libregrtest/runtest.py", line 315 in _runtest_inner2
  File "/Users/user/oss/cpython/Lib/test/libregrtest/runtest.py", line 360 in _runtest_inner
  File "/Users/user/oss/cpython/Lib/test/libregrtest/runtest.py", line 235 in _runtest
  File "/Users/user/oss/cpython/Lib/test/libregrtest/runtest.py", line 265 in runtest
  File "/Users/user/oss/cpython/Lib/test/libregrtest/main.py", line 456 in run_tests_sequential
  File "/Users/user/oss/cpython/Lib/test/libregrtest/main.py", line 574 in run_tests
  File "/Users/user/oss/cpython/Lib/test/libregrtest/main.py", line 752 in _main
  File "/Users/user/oss/cpython/Lib/test/libregrtest/main.py", line 711 in main
  File "/Users/user/oss/cpython/Lib/test/libregrtest/main.py", line 775 in main
  File "/Users/user/oss/cpython/Lib/test/__main__.py", line 2 in <module>
  File "/Users/user/oss/cpython/Lib/runpy.py", line 88 in _run_code
  File "/Users/user/oss/cpython/Lib/runpy.py", line 198 in _run_module_as_main

Extension modules: _testcapi, _testmultiphase, _testsinglephase, _testinternalcapi (total: 4)
[1]    83285 abort      ./python.exe -m test test_capi -R 3:3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@corona10

corona10 commented Mar 1, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

buildbot/s390x RHEL7 Refleaks PR

Unrelated to this PR.

Issue created to: #102351

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@corona10
corona10 requested a review from erlend-aasland March 2, 2023 02:59
erlend-aasland
erlend-aasland reviewed Mar 2, 2023
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit to make the comment slightly clearer. Perhaps also add code to assert that we could successfully revert to the initial value?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Modules/_testcapi/code.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@encukou @erlend-aasland
Update comment
18cdc8a
Co-authored-by: Erlend E. Aasland <[email protected]>
@encukou

encukou commented Mar 2, 2023

Copy link
Copy Markdown
Member

Ah, that's right. The test needs to clean up after itself so it can be run again.
Thank you for the fix!

corona10 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

encukou
encukou approved these changes Mar 2, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Mar 2, 2023
@corona10
corona10 merged commit ed55c69 into python:main Mar 2, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 2, 2023
@corona10
corona10 deleted the gh-101101-fix branch March 2, 2023 11:32
@iritkatriel iritkatriel mentioned this pull request Mar 2, 2023
s390x RHEL7 got crash on the refleak test #102351
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland left review comments
@encukou encukou encukou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@corona10 @bedevere-bot @encukou @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.