GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-102356: Add thrashcan macros to filter object dealloc (GH-102426) by miss-islington · Pull Request #102435 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Mar 5, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Add thrashcan macros to the deallocator of the filter objects to protect against deeply nested destruction of chains of nested filters.
(cherry picked from commit 66aa78c)

Co-authored-by: Marta Gómez Macías [email protected]

  • Issue: Stack overflow on GC of deeply nested filter() #102356

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mgmacias95 @miss-islington
pythongh-102356: Add thrashcan macros to filter object dealloc (pytho…
060e8ac 
…nGH-102426)

Add thrashcan macros to the deallocator of the filter objects to protect against deeply nested destruction of chains of nested filters.
(cherry picked from commit 66aa78c)

Co-authored-by: Marta Gómez Macías <[email protected]>
This was referenced Mar 5, 2023
Stack overflow on GC of deeply nested filter() #102356
Closed
gh-102356: Add trashcan macros to filter object dealloc #102426
Merged
@bedevere-bot bedevere-bot added type-crash A hard crash of the interpreter, possibly with a core dump awaiting review labels Mar 5, 2023
pablogsal
pablogsal approved these changes Mar 5, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 5, 2023
@miss-islington
miss-islington merged commit 63fd954 into python:3.11 Mar 5, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 5, 2023
@miss-islington
miss-islington deleted the backport-66aa78c-3.11 branch March 5, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @pablogsal @bedevere-bot @mgmacias95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.