GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] Fix unused classes in a typing test (GH-102437) by miss-islington · Pull Request #102442 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Mar 5, 2023

Copy link
Copy Markdown
Contributor

As part of investigation issue #102433, I discovered what I believe to be an error where two classes CI and DI are not being used. The assertions beneath them act on C and D, duplicating existing assertions in this test.
(cherry picked from commit 7894bbe)

Co-authored-by: JosephSBoyle [email protected]
Automerge-Triggered-By: GH:AlexWaygood

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JosephSBoyle @miss-islington
Fix unused classes in a typing test (pythonGH-102437)
2aa63d7 
As part of investigation issue python#102433, I discovered what I believe to be an error where two classes `CI` and `DI` are not being used. The assertions beneath them act on `C` and `D`, duplicating existing assertions in this test.
(cherry picked from commit 7894bbe)

Co-authored-by: JosephSBoyle <[email protected]>
Automerge-Triggered-By: GH:AlexWaygood
@miss-islington
miss-islington requested review from AlexWaygood, Fidget-Spinner, JelleZijlstra and gvanrossum as code owners March 5, 2023 15:07
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Mar 5, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 5, 2023
Fix unused classes in a typing test #102437
Merged
@bedevere-bot bedevere-bot added skip issue skip news awaiting review labels Mar 5, 2023
AlexWaygood
AlexWaygood approved these changes Mar 5, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 5, 2023
@AlexWaygood AlexWaygood self-assigned this Mar 5, 2023
@miss-islington
miss-islington merged commit 94e08e1 into python:3.10 Mar 5, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 5, 2023
@miss-islington
miss-islington deleted the backport-7894bbe-3.10 branch March 5, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AlexWaygood AlexWaygood

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @AlexWaygood @bedevere-bot @JosephSBoyle
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.