GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-102519: Add os.listdrives, os.listvolumes and os.listmounts on Windows by zooba · Pull Request #102544 · python/cpython

Conversation

@zooba

@zooba zooba commented Mar 8, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Add os.listdrives on Windows #102519

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@zooba
pythongh-102519: Add os.listdrives, os.listvolumes and os.listmounts …
cafd311
…on Windows
@bedevere-bot bedevere-bot mentioned this pull request Mar 8, 2023
Add os.listdrives on Windows #102519
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Mar 8, 2023
@zooba zooba added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 9, 2023
@bedevere-bot

bedevere-bot commented Mar 9, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zooba for commit cafd311 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 9, 2023
eryksun
eryksun reviewed Mar 9, 2023
View reviewed changes
Comment thread Modules/posixmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

zooba added 3 commits March 9, 2023 15:59
@zooba
Improved buffer handling
2d807c9
@zooba
Verify volume before searching
3147f63
@zooba
Merge remote-tracking branch 'cpython/main' into pythongh-102519
afaa312
eryksun
eryksun reviewed Mar 9, 2023
View reviewed changes
Comment thread Modules/posixmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@zooba
Simplify listdrives implementation
193260a
eryksun
eryksun reviewed Mar 10, 2023
View reviewed changes
Comment thread Modules/posixmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@zooba @eryksun
Update Modules/posixmodule.c
d29b295
Co-authored-by: Eryk Sun <[email protected]>
@zooba

zooba commented Mar 10, 2023

Copy link
Copy Markdown
Member Author

I'm going to go ahead and assume that if all you've found is whitespace, there are no problems left to find 😉

Thanks for the review, as always. Really appreciate having you check this stuff out

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zooba
zooba merged commit cb35882 into python:main Mar 10, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Mar 10, 2023
@zooba
zooba deleted the gh-102519 branch March 10, 2023 12:21
@eryksun

eryksun commented Mar 10, 2023

Copy link
Copy Markdown
Contributor

I'm going to go ahead and assume that if all you've found is whitespace, there are no problems left to find wink

I thought you weren't finished yet since the PR doesn't document the new functions in "Doc/library/os.rst".

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zooba

zooba commented Mar 10, 2023

Copy link
Copy Markdown
Member Author

Weird, I definitely wrote those docs... I wonder where they've gone

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@zooba zooba mentioned this pull request Mar 10, 2023
gh-102519: Add doc updates for os.listdrives, listvolumes and listmounts #102585
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eryksun eryksun eryksun left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@zooba @bedevere-bot @eryksun
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.