GeezerVison is showing github.com — [3.10] GH-102537: Handle check for PYTHONTZPATH failing in zoneinfo test (GH-102538) by miss-islington · Pull Request #102587 · python/cpython
Conversation
miss-islington
commented
Mar 10, 2023
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
It is possible but unlikely for the python_tzpath_context function to fail between the start of the try block and the point where os.environ.get succeeds, in which case old_env will be undefined. In this case, we want to take no action.
Practically speaking this will really only happen in an error condition anyway, so it doesn't really matter, but we should probably do it right anyway.
(cherry picked from commit 64bde50)
Co-authored-by: Paul Ganssle [email protected]
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…st (pythonGH-102538)
It is possible but unlikely for the `python_tzpath_context` function to fail between the start of the `try` block and the point where `os.environ.get` succeeds, in which case `old_env` will be undefined. In this case, we want to take no action.
Practically speaking this will really only happen in an error condition anyway, so it doesn't really matter, but we should probably do it right anyway.
(cherry picked from commit 64bde50)
Co-authored-by: Paul Ganssle <[email protected]>
This was referenced Mar 10, 2023
|
The docs failure was a bug in python-docs-theme, now fixed and released (python/python-docs-theme#113).
I've restarted it and it passes now ✅
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
pganssle
pganssle approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
tests
Tests in the Lib/test dir
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.