GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] Remove misformatted exclamation marks in docs (GH-102694) by hugovk · Pull Request #102716 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Mar 15, 2023

Copy link
Copy Markdown
Member

(cherry picked from commit 8647ba4)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tom93 @hugovk
[3.11] Remove misformatted exclamation marks in docs (pythonGH-102694)
71098e4
Remove the exclamation mark from :program:`!foo` in .rst files because
it inadvertently shows up in the rendered HTML.

(Sphinx's cross-referencing roles use a '!' prefix to suppress
hyperlinking[1], but :program: is not a cross-referencing role so the
'!' is displayed verbatim.)

The exclamation marks in venv.rst were introduced in pythonGH-98350. See
comments [2] and [3] for additional discussion.

[1]: https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.htmlGH-cross-referencing-syntax
[2]: https://github.com/python/cpython/pull/98350GH-issuecomment-1285965759
[3]: https://github.com/python/cpython/pull/98350GH-issuecomment-1286394047

Reported-by: Vinay Sajip <[email protected]>.
(cherry picked from commit 8647ba4)

Co-authored-by: Tom Levy <[email protected]>
@hugovk
hugovk requested a review from vsajip as a code owner March 15, 2023 07:13
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir skip news labels Mar 15, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 15, 2023
Remove misformatted exclamation marks in docs #102694
Merged
@bedevere-bot bedevere-bot added skip issue awaiting core review labels Mar 15, 2023
@hugovk
hugovk merged commit 6b6c2f5 into python:3.11 Mar 15, 2023
@hugovk
hugovk deleted the backport-8647ba4-3.11 branch March 15, 2023 07:25
@bedevere-bot bedevere-bot removed the awaiting core review label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @bedevere-bot @tom93
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.