GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-63062: Implement __subclasshook__() for Finders and Loaders in abc lib by furkanonder · Pull Request #102763 · python/cpython

Conversation

@furkanonder

@furkanonder furkanonder commented Mar 16, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Implement __subclasshook__() for Finders and Loaders in importlib.abc #63062

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@furkanonder
Implement __subclasshook__() for Finders and Loaders
34ecd94
@bedevere-bot bedevere-bot mentioned this pull request Mar 16, 2023
Implement __subclasshook__() for Finders and Loaders in importlib.abc #63062
Open
@bedevere-bot bedevere-bot added the awaiting review label Mar 16, 2023
@blurb-it
📜🤖 Added by blurb_it.
8bd3d71
@ericsnowcurrently
ericsnowcurrently requested review from brettcannon and ericsnowcurrently March 17, 2023 14:52
@furkanonder
Mention the authors
05f245d
@brettcannon

brettcannon commented May 12, 2023

Copy link
Copy Markdown
Member

FYI there's a merge conflict.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon
brettcannon removed their request for review June 9, 2023 22:29
@brettcannon

brettcannon commented Jun 9, 2023

Copy link
Copy Markdown
Member

To keep my review queue clean, I'm removing myself to review until the merge conflict is fixed. Feel free to add me back once the conflict is fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@furkanonder
Merge branch 'main' into issue-63062
7474b22
@furkanonder
furkanonder requested review from brettcannon, ncoghlan and warsaw as code owners June 10, 2023 20:45
@furkanonder

furkanonder commented Jun 10, 2023

Copy link
Copy Markdown
Contributor Author

This PR seems to deprecate find_loader and find_module. For this reason I think it makes sense to close the PR. @brettcannon What do you think?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon

brettcannon commented Jun 16, 2023

Copy link
Copy Markdown
Member

@furkanonder it's your PR so if you think it should be closed I'm fine with that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon brettcannon closed this Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@furkanonder @brettcannon @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.