GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-102721: Improve coverage of `_collections_abc._CallableGenericAlias` by sobolevn · Pull Request #102790 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Mar 17, 2023 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is a manual backport of #102722 but without typing.py changes and without TypeVarTuple case, because it was added in 3.11

  • Issue: Improve coverage of _collections_abc._CallableGenericAlias #102721

Automerge-Triggered-By: GH:AlexWaygood

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
[3.10] pythongh-102721: Improve coverage of `_collections_abc._Callab…
06a619b 
…leGenericAlias`
@sobolevn
sobolevn requested review from AlexWaygood, Fidget-Spinner, JelleZijlstra and gvanrossum as code owners March 17, 2023 19:18
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Mar 17, 2023
@bedevere-bot bedevere-bot mentioned this pull request Mar 17, 2023
Improve coverage of _collections_abc._CallableGenericAlias #102721
Closed
@bedevere-bot bedevere-bot added the awaiting review label Mar 17, 2023
@AlexWaygood AlexWaygood added the skip news label Mar 17, 2023
@sobolevn
Update test_typing.py
0736c9a
AlexWaygood
AlexWaygood approved these changes Mar 17, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 17, 2023
@AlexWaygood AlexWaygood added the 🤖 automerge label Mar 17, 2023
@AlexWaygood AlexWaygood self-assigned this Mar 17, 2023
@miss-islington

miss-islington commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

@sobolevn: Status check is done, and it's a failure or timed out ❌.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Eclips4
Eclips4 reviewed Mar 17, 2023
View reviewed changes
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood @Eclips4
Update Lib/test/test_typing.py
0d00d46 
Co-authored-by: Eclips4 <[email protected]>
@miss-islington

miss-islington commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 3 of 6 required status checks are expected..
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Mar 17, 2023

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅.
AlexWaygood and Eclips4 reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit e732a85 into python:3.10 Mar 17, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes
@Eclips4 Eclips4 Eclips4 left review comments
@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AlexWaygood AlexWaygood

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sobolevn @miss-islington @AlexWaygood @Eclips4 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.